GithubHelp home page GithubHelp logo

Comments (7)

geelen avatar geelen commented on May 29, 2024 1

Right it's due to missing Symbol on IE. We're not using it, but postcss is using for (let x in y) and babel transpiles that to something that uses Symbol.

There's a small core-js symbol polyfill we should be able to use: https://github.com/zloirock/core-js/blob/v2.4.1/modules/es6.symbol.js

...but I won't get to that till tomorrow at the earliest. The real solution would be to change postcss to not use those loops, but that might be a while before I can do that one.

from styled-components.

mxstbr avatar mxstbr commented on May 29, 2024

It's interesting that it doesn't render on IE at all, not sure if that's a thing we messed up or react or something. Do you have access to logs in the console of those browsers? Let's get that support up!

from styled-components.

amsb avatar amsb commented on May 29, 2024

I updated my example app to make it easier to test on the BrowserStack snapshots page Microsoft hosts and explicitly imported symbol from core-js at the top of my entrypoint (I think create-react-app might already be including it, but just to be sure). No luck, but maybe test doesn't remedy the need for Symbol deeper into the dependency tree?

from styled-components.

geelen avatar geelen commented on May 29, 2024

Turned out to be easier than I thought. Pushed PR #91.

from styled-components.

amsb avatar amsb commented on May 29, 2024

Thanks @geelen and @mxstbr! I confirm that my example app now renders on IE11. I assume the browser compatibility matrix for styled-components doesn't include IE10 or earlier since Microsoft isn't supporting these browsers on the desktop anymore themselves (with the exception of IE9 on Vista which will be EOL'ed April 2017).

Nevertheless, I'd be curious if any older versions of IE could be supported with a polyfill and think it would be helpful to have a sentence in the README communicating the browser compatibility targets.

from styled-components.

mxstbr avatar mxstbr commented on May 29, 2024

Nevertheless, I'd be curious if any older versions of IE could be supported with a polyfill

Is there any errors in the console for earlier versions? What's missing?

from styled-components.

amsb avatar amsb commented on May 29, 2024

I downloaded an IE10 VM and dug deeper to find the issue, but someone else beat me to posting it and submitted #107. :)

from styled-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.