Comments (7)
Right it's due to missing Symbol
on IE. We're not using it, but postcss is using for (let x in y)
and babel transpiles that to something that uses Symbol.
There's a small core-js
symbol polyfill we should be able to use: https://github.com/zloirock/core-js/blob/v2.4.1/modules/es6.symbol.js
...but I won't get to that till tomorrow at the earliest. The real solution would be to change postcss to not use those loops, but that might be a while before I can do that one.
from styled-components.
It's interesting that it doesn't render on IE at all, not sure if that's a thing we messed up or react or something. Do you have access to logs in the console of those browsers? Let's get that support up!
from styled-components.
I updated my example app to make it easier to test on the BrowserStack snapshots page Microsoft hosts and explicitly imported symbol from core-js at the top of my entrypoint (I think create-react-app might already be including it, but just to be sure). No luck, but maybe test doesn't remedy the need for Symbol deeper into the dependency tree?
from styled-components.
Turned out to be easier than I thought. Pushed PR #91.
from styled-components.
Thanks @geelen and @mxstbr! I confirm that my example app now renders on IE11. I assume the browser compatibility matrix for styled-components doesn't include IE10 or earlier since Microsoft isn't supporting these browsers on the desktop anymore themselves (with the exception of IE9 on Vista which will be EOL'ed April 2017).
Nevertheless, I'd be curious if any older versions of IE could be supported with a polyfill and think it would be helpful to have a sentence in the README communicating the browser compatibility targets.
from styled-components.
Nevertheless, I'd be curious if any older versions of IE could be supported with a polyfill
Is there any errors in the console for earlier versions? What's missing?
from styled-components.
I downloaded an IE10 VM and dug deeper to find the issue, but someone else beat me to posting it and submitted #107. :)
from styled-components.
Related Issues (20)
- Theme prop (not styled) is not being passed through HOT 1
- Feature request for v5 to ease migration to v6 of large ecosystems
- Interplay of `shouldForwardProp` clarifying question
- Export the `toStyleSheet` function HOT 3
- createGlobalStyle not working version >= 5.3.1 HOT 1
- [Docs] Lint for pseudo selectors - Styled Components update from v5 to v6 HOT 1
- Tailwind selectors do not work the expected (from me) way
- React SSR Streaming Bug
- Error while building project after upgrading from 5.3.11 to 6.0.0 HOT 2
- styled-components is ~50% larger than it could be due to IE11 support HOT 1
- Cannot infer the 'as' and 'forwardedAs' props by React.ComponentProps
- Ssr not picking up styled components from an npm package HOT 1
- error TS4023 when compiling a library that uses "styled-components": "^6.1.9" HOT 4
- Required attrs type fixes for 6.1.9 not applied when using prop factory
- Types of `.attrs` are still broken for React Native on 6.1.9 when using `styled()` HOT 2
- Required attrs type fixes for 6.1.9 not applied when using union props HOT 1
- Heap issues in latest 6.1.9 HOT 3
- Regression: `typeof` on a styled component returns incompatible type HOT 1
- toHaveStyleRule assertion fails after upgrading to 6.1.10 HOT 2
- Use changesets
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from styled-components.