ThemeProvider breaks react-storybook about styled-components

[vernondegoede]

@kopax https://gist.github.com/vernondegoede/0575d268d52e00f221cc86057fb938d1

[vernondegoede]

Yes, it's working fine. Just use the addDecorator method which comes with react-storybook.

[mxstbr]

/cc @arunoda @mnmtanish, maybe you have some input about how you're using context before I find time to dig in?

[mxstbr]

Thank you for reporting this, I will take a look today! Sounds like they rely on some context updates which we might or might not be blocking.

[mxstbr]

Can you retry with v1.0.4 of styled-components? If it was a context issue that should've fixed it.

[thani-sh]

I just checked it out. The bug is still there.
https://github.com/mnmtanish/storybook_styled-components_example/pull/2

[mxstbr]

Thank you, this does seem to be something else then! Any errors in the console?

[amsb]

No errors in console.

[arunoda]

@mxstbr I didn't try this yet or read the code in full.
But I suspect the issue lies here

Components rendered on Storybook never see componentWillReceiveProps hook. That's because we always do the initial rendering.

[mxstbr]

Components rendered on Storybook never see componentWillReceiveProps hook. That's because we always do the initial rendering.

I don't quite understand this – shouldn't the components still receive props?

[arunoda]

@mxstbrcomponentWillReceiveProps is no called in the initial render. In React Storybook, we only the do the initial render.

[thuringia]

Hi everyone,
not sure if this is related but I get a TypeError due to ThemeProvider#unsubscribeToOuter being undefined in componentWillUnmount.

[mxstbr]

@thuringia which version are you on? I'm pretty sure we fixed that a week or two ago!

[thuringia]

@mxstbr apparently we're still using 1.0.3. Seems like somebody pinned the versions without my knowledge. Sorry!

[jjstrat3]

@arunoda pardon my ignorance, but your statement about React Storybook only doing the initial render confuses me. With addons like Knobs, I'm able to change props in realtime...how would this be different??

[kopax]

Is react-storybook now working with styled ?

[kopax]

One last thing, @vernondegoede what should be the parameter passed to addDecorator ?