Comments (7)
Done by the amazing @nickgnd in #121! 🎉
from styled-components.
Hi @mxstbr, I'd like work on this 😄
I'll let you know how i proceed and I'll send you PR asap
from styled-components.
Awesome, let me know how it goes!
from styled-components.
Hey @nickgnd, just wondering if you maybe ran into issues? Can I help?
from styled-components.
Hi @mxstbr, it's all ok :) Thanks for your interesting. I think I'll be able to send you a PR tomorrow night with almost all the rules you listed in the first comment, then we can improve them to better fit the project's needs.
The only thing a bit difficult is to test the rules specified because, also if I run Danger locally, it tests the rules against the latest Github PR, but it's not blocking
from styled-components.
I think I'll be able to send you a PR tomorrow night with almost all the rules you listed in the first comment, then we can improve them to better fit the project's needs.
Awesome, sounds good to me! Feel free to submit a WIP PR so you can iterate on the output, that should also solve the second issue!
from styled-components.
@mxstbr wow, thanks! Let me know if you need further help to adjust Danger's rules or in other on ruby stuff 🤓 💎
from styled-components.
Related Issues (20)
- styled-components is ~50% larger than it could be due to IE11 support HOT 1
- Cannot infer the 'as' and 'forwardedAs' props by React.ComponentProps
- Ssr not picking up styled components from an npm package HOT 1
- error TS4023 when compiling a library that uses "styled-components": "^6.1.9" HOT 4
- Required attrs type fixes for 6.1.9 not applied when using prop factory
- Types of `.attrs` are still broken for React Native on 6.1.9 when using `styled()` HOT 4
- Required attrs type fixes for 6.1.9 not applied when using union props HOT 1
- Heap issues in latest 6.1.9 HOT 3
- Regression: `typeof` on a styled component returns incompatible type HOT 1
- toHaveStyleRule assertion fails after upgrading to 6.1.10 HOT 2
- Use changesets
- Clear cache on view transition
- V6 breaks value-object toString stylesheet interpolation
- Class instance returned from function interpolation causes Component is not a styled component error in v6
- Setting prop via `.attrs()` is not making the prop on the final component optional HOT 1
- Why was ThemedStyledInterface removed?
- Vite Production error 6.1.11
- Styled Components is Slow in Chrome
- Best docker image for jdk and maven
- Version 6.0.0 requires node to be above 15, not >= 14 as stated in the document
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from styled-components.