GithubHelp home page GithubHelp logo

bug: Cannot build Viper about viper HOT 5 CLOSED

0negal avatar 0negal commented on June 18, 2024
bug: Cannot build Viper

from viper.

Comments (5)

0neGal avatar 0neGal commented on June 18, 2024

Not only do I not get this error, but the package-lock.json states it is only an optional dependency of dmg-builder, which is a dependency of electron-builder as you noticed as well.

"node_modules/dmg-builder": {
	"version": "22.14.5",
	"resolved": "https://registry.npmjs.org/dmg-builder/-/dmg-builder-22.14.5.tgz",
	"integrity": "sha512-1GvFGQE332bvPamcMwZDqWqfWfJTyyDLOsHMcGi0zs+Jh7JOn6/zuBkHJIWHdsj2QJbhzLVyd2/ZqttOKv7I8w==",
	"dev": true,
	"dependencies": {
		"app-builder-lib": "22.14.5",
		"builder-util": "22.14.5",
		"builder-util-runtime": "8.9.1",
		"fs-extra": "^10.0.0",
		"iconv-lite": "^0.6.2",
		"js-yaml": "^4.1.0"
	},
	"optionalDependencies": {
		"dmg-license": "^1.0.9"
	}
},

It being deprecated shouldn't affect you. Furthermore, when I re-install from the bottom up, it never gets installed by npm. So for some reason it doesn't get passed as optional for you.

from viper.

Alystrasz avatar Alystrasz commented on June 18, 2024

I think it's related to my npm version (v6), which struggles with lockfile version 2 (as displayed on my screenshot).

After updating to npm v8.3.1, I had no problem installing dependencies.
Maybe we should mention that somewhere?

from viper.

0neGal avatar 0neGal commented on June 18, 2024

Maybe we should mention that somewhere?

I'm not sure that's so important, also considering there's a warning directly saying what's wrong (even tho we both managed to miss it), so I don't think it's something that really matters. How did you even manage to use npm 6 this time, but npm 7 or newer in the past?

from viper.

Alystrasz avatar Alystrasz commented on June 18, 2024

For professional reasons, I've been using node version 14 (shipped with npm 6), which is still supported: https://nodejs.org/en/about/releases/

I build my packages for node v14 and v16 at the same time: in this case, lockfile warning does not prevent package from being built for both versions with npm 6.

(I use several computers to work, and it seems they have different npm versions without me noticing it...)

from viper.

0neGal avatar 0neGal commented on June 18, 2024

Ah, I see, didn't know npm 6 had LTS releases, but ig it makes sense considering how big a difference lockfile v2 has over v1 (iirc v2 came with npm 7), and there's probably even more breaking changes for some use cases.

I think unless we get more reports of people not noticing npm 7 and up is required we'll leave it like it is, otherwise we can add a tiny "notice" in the Development section of the README.

from viper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.