Detach? about vessel

[prologic]

Hi @0xc0d 👋 I wanted to let you know that I eventually managed to fix support for running containers detached with a -d/--detach flag. See this PR and attached screenshot showing this working 👌

In the end I had to:

1. Ensure important devices such as /dev/null were available in the container's filesystem. So I borrowed some code from GoNix to do this CreateDevices() once we're inside the new container's namespace and filesystem.
2. Set the SysProcAttr(s) Pgid: 0 and Setpgid: true in the parent process of the container -- That is run.go for me (probably similar for you)
3. Ensure that the container process (_the forked or init process, which for me is in fork.go and ends up being the parent process, or supervisor of the actual binary being run in the container /proc/self/exe) actually waits on the container process. It is in fact the parent process, the one that sets things up (gun.go for me) where you can start and essentially terminate, but obviously not without setting up the mentioned SysProgAttr(s) above so the process has its own process group and session.

Finally I think its also important not to attach the terminal's standard fds to any part of the process either.

[0xc0d]

Hi @prologic,

Thank you for your question. I just realized that my implementation was not alright.
For detaching you need to release the underneath process from the parent.

[prologic]

Hi @prologic,

Thank you for your question. I just realized that my implementation was not alright. For detaching you need to release the underneath process from the parent.

Yup 😅 Some of my code was/is inspired by your project and I realized this too, hence why I asked. Unfortunately it doens't seem to be as easy as "separate the process from the parent" 😅

[prologic]