GithubHelp home page GithubHelp logo

Comments (5)

tott avatar tott commented on August 16, 2024

Hi,

we're going to have a look at this issue and will let you know if we need any further feedback from you.

Thanks
Thorsten

from windows-azure-storage.

eugene-manuilov avatar eugene-manuilov commented on August 16, 2024

Hi @kdlarson,

I have checked it on my local and it works correctly. Could you please tell me what theme do you use and if there any other plugin activated?

from windows-azure-storage.

kdlarson avatar kdlarson commented on August 16, 2024

I created a vanilla WordPress install on Azure with only the Window Azure Storage plugin activated and using the default Twenty Seventeen theme.

In the default configuration, everything works -- both storage and cdn work perfectly.

But when I uncheck the option for WordPress to store media in year/month folder structure (Settings - Media - Organize my uploads into month- and year-based folders), I see the following two bugs:

  1. Responsive image versions stored with zero bytes (original file stored correctly)
  2. Anywhere the uploaded image is used, srcset does not include cdn path (see below)

Image Stored using year/month folders:

<img width="233" height="300" class="alignnone size-medium wp-image-4" alt="" src="https://schoolerz-media-test2.azureedge.net/media/2017/10/Big_buck_bunny_poster_big-233x300.jpg" srcset="https://schoolerz-media-test2.azureedge.net/media/2017/10/Big_buck_bunny_poster_big-233x300.jpg 233w, https://schoolerz-media-test2.azureedge.net/media/2017/10/Big_buck_bunny_poster_big-768x990.jpg 768w, https://schoolerz-media-test2.azureedge.net/media/2017/10/Big_buck_bunny_poster_big-794x1024.jpg 794w" sizes="(max-width: 233px) 100vw, 233px">

Image stored with "Organize my uploads into month- and year-based folders" unchecked:
<img width="233" height="300" class="alignnone size-medium wp-image-6" alt="" src="https://schoolerz-media-test2.azureedge.net/media/sintel_poster-233x300.jpg" srcset="/wp-content/uploads/sintel_poster-233x300.jpg 233w, /wp-content/uploads/sintel_poster-768x990.jpg 768w, /wp-content/uploads/sintel_poster-794x1024.jpg 794w, /wp-content/uploads/sintel_poster.jpg 993w" sizes="(max-width: 233px) 100vw, 233px">

Thanks for taking a look at this, and for the great plugin.

from windows-azure-storage.

eugene-manuilov avatar eugene-manuilov commented on August 16, 2024

Thanks, @kdlarson! It helped a lot. I have fixed these issues and created a new pre-release (4.0.3). Could you please try it on your setup and let us know if it helps you or not? Thanks in advance!

https://github.com/10up/windows-azure-storage/releases

from windows-azure-storage.

kdlarson avatar kdlarson commented on August 16, 2024

Great job, @eugene-manuilov! In my testing, all features work perfectly. I tested it in both my basic vanilla WP install and also in my heavy and complex "real" site. Thanks very much for fixing this so quickly.

from windows-azure-storage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.