GithubHelp home page GithubHelp logo

Comments (1)

17cupsofcoffee avatar 17cupsofcoffee commented on June 10, 2024 2

Some background: the reason TetraError generally doesn't include the inner errors in the Display impl is because this doesn't play nicely with error reporting libraries like anyhow or eyre, which use Error::source to print a nice stack with all the nested errors. If you include the source in Display as well as context, you get duplication in the output.

For this reason, the Rust error handling project group recommends that nested errors should either be returned from Display or source, but not both.

The problem is, for PlatformError, InvalidShader, FailedToChangeDisplayMode and TessellationError, I'm not returning them from either 🤦🤦🤦

This is an oversight on my part - those four errors can't return their causes from source (due to the nested types not implementing Error), so I should show them via Display instead.

I will try to fix this issue tomorrow.

As a workaround, if you print the error with Debug, you should be able to see what message is inside it.

from tetra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.