Comments (4)
@eigenbom i know you cared about this
I think they should probably be split to per-module tests rather than one big file. i think I don't mind them being in .test
directory rather than a branch as it's not too hard to filter out or delete prior to packaging, and i think the default zip tool will ignore the filenames with a dot anyway.
from batteries.
I don't know if you can put the github actions configuration anywhere except .github/
in the root of the repo. In theory, we could put the tests inside there. Unusual and makes them less discoverable, but a single superfluous directory to delete.
I agree about putting them in a folder and splitting them up.
CI detects PRs and pushes to this repo, so the yml needs to be in this repo to work. In theory CI could even merge batteries to the test repo on a push to this repo, but I don't know anything about handling github secrets/auth to allow that kind of setup. Doesn't seem worth the effort.
Putting them in another repo seems easier than a test branch. I guess that repo could have scripts for running the tests on different platforms and even include testy so no luarocks is required.
Personally, I'd rather they're in this repo because I think it's more likely someone will see them and actually add a test (and it's easier for me to do so too). Adding tests that are tied to code changes would be much easier.
from batteries.
(Github yaml in the github folder is fine.)
I'm happy with the tests in .test
so far, i think.
As a submodule, adding an exclusion on dotfiles when zipping for distribution works well and strips both .github
, and .test
, and more importantly all the git history.
With plain zip
on arch linux:
zip -r -x*/.* batteries.zip path/to/batteries/
Gives a clean zip with the lua, readme, and license files.
When just grabbing the zip off github, it's easy to just leave out the dotfiles when extracting.
from batteries.
Closing this, I think we're fine with it.
from batteries.
Related Issues (20)
- `functional.reduce` has an annoying signature HOT 1
- Bug in state machine ctor HOT 1
- `state_machine` variable name refactoring HOT 1
- [Feature Request] tablex.print_r HOT 4
- Use LuaJIT's `table.clear` when possible. HOT 1
- colour.lua: hex_to_rgb HOT 1
- [Feature Request] path module HOT 5
- [Future Request] :camelCase() should make the first letter of a class uppercase HOT 1
- functional.generate_2d returns no result HOT 1
- Return index with functional's "find" functions HOT 1
- Explain dependency on "bit" library, colour.lua fails to load on native lua 5.1 HOT 1
- Docs improvement re package.path HOT 3
- mathx.random_lerp should call mathx.lerp
- rgb_to_hsl h is unassigned HOT 2
- set referred to, but not required() HOT 1
- intersect.nearest_point_on_line math should be mathx HOT 1
- [Bug]: Subclass Not Updating Parent Variables HOT 4
- table.rotate should use the triple reverse method. HOT 1
- attempt to index a nil value (global 'love') HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from batteries.