GithubHelp home page GithubHelp logo

Comments (6)

neurowave avatar neurowave commented on August 19, 2024

This will also improve how this looks on the iPhone XS max (and XR)…

Simulator Screen Shot - iPhone Xs Max - 2019-04-26 at 16 13 18

from developer_quest.

efortuna avatar efortuna commented on August 19, 2024

It also feels too narrow. I'd like it to be a little wider, or at least some more padding arouind the edges

from developer_quest.

neurowave avatar neurowave commented on August 19, 2024

@efortuna I think that's because it's the exaggerated height that's making it look that way. I went ahead and updated the designs with extra padding and bigger font size with better line-height for the body text. Adding this to Zeplin!

Character Modal

from developer_quest.

neurowave avatar neurowave commented on August 19, 2024

I updated these with a dark background since the glows behind most of the characters aren't looking so great on white backgrounds. Here's how it looks…

Character Modal dark
Character Modal Tablet dark

from developer_quest.

luigi-rosso avatar luigi-rosso commented on August 19, 2024

Looks like this if we set the max height to 75% of the max width:
image

from developer_quest.

neurowave avatar neurowave commented on August 19, 2024

That's definitely better!

from developer_quest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.