Array Concatenation about 30-seconds-of-code

[darrenscerri]

Right, the only advantage of Lodash's concat is safety. arr can be a non-array value and the function would not throw an error. ArrayConcat doesn't provide this safety, so essentially it is identical to Array.concat in terms of behaviour, functionality and safety.

[Chalarangelo]

I didn't test, I thought it was working, seemed simple enough. The idea was to duplicate lodash's concat behavior. Any suggested fixes or improvements?

[Chalarangelo]

Ok, I just fixed the example to show what it should.

[Chalarangelo]

Great point! I am reading lodash's concat and I see what you mean. We should improve our arrayConcat to provide the same functionality. PR anyone?

[skatcat31]

So what I'm hearing is that we should have a ternary/type check for .concat()?

[Chalarangelo]

@skatcat31 sounds like it! If you want/can, PR it at some point. I want this resolved asap.

[sabareeshkk]

@darrenscerri @Chalarangelo this will do the trick right?
const arrayCo ncat = (arr, ...args) => [].concat(arr, ...args);
this creates a new array and no error thrown the arr is not an array

[skatcat31]

@sabareeshkk

arrayConcat({}, {}) // [{},{}]

There are many other odd edge cases with that sort of thing. maybe just let it crash. If the developer tried to concat something without type checking it, wouldn't the best option be to let the error bubble in proper design?

[darrenscerri]

To be honest, don't think adding safety to native APIs is the scope of this repo. Thoughts @Chalarangelo ?

[Chalarangelo]

I wrote the snippet to implement lodash's concat which in itself is something between a polyfill and a method that deals with some corner cases. I wouldn't mind keeping the improved snippet, just to showcase the technique, but we might not actually need it in the long run. I'll probably merge the PR with the change and let it sit for a while untagged while we discuss this further.

[Chalarangelo]

This was resolved (as far as I can tell) in #148.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks.