sound loop when enemy drops weapon too close to walls (ex. doomforever-redux) about edge

[Corbachu]

It's been a crazy week for us -- finally back at it, will check this out tonight!! =D

[Corbachu]

We have fixed this in the latest Git revision - please try this out again, and if it comes up then we will inspect it. If not, I will close and mark as fixed! =)

Specifically tested with Duke it out in DOOM.

[ryan-sg]

hmm, i was able to quickly reproduce the problem still with doom4ever-redux, still on map02, right after I shot the shotguy behind the red key bars his shotty landed too close to the wall and clickityclickityclickity....etc

i'm at revision 4fac0fb, plus my 'merge' to my local branch, plus my bsd-makefile-fix commit.

EDIT: I gave the Duke it out in DOOM mod a try again, and much to my surprise multiple plays through map02 and even into map03 I wasn't able to reproduce the sound loop issue in this mod now.

A couple quick notes as I have to run out the door, if they are problems I will open separate issues (DukeOut-related):

• Duke's voice seems to get the pitch-shifting sound treatment, so several times it sounds like hes getting drunk :D
• barrels are all drawn off the floor so they look like they're floating/hanging off the walls. They also seem slightly out of place, as you need to shoot the empty space where they are supposed to be for them to explode

[Corbachu]

Issue 1: Yes, the pitch shift table needs slight improvements =D

Issue 2: This was recently fixed in commit 0e564ba, so please check that and make sure it is indeed fixed.

I'm going to close this now -- if you feel like it should be re-opened (since none of us can replicate the issue now), let me know and I'll re-open it.

[ryan-sg]

I hope commenting on this doesn't auto-reopen it, but just for clarification do you mean that you guys also tried doomforever-redux (doom4ever-redux?) and can't reproduce the issue there whereas I still can? Before I say much more i'm pulling the latest changes anyway and I'll double check again. Cheers!

[ryan-sg]

:( I was able to reproduce the issue again in DukeOut just now, bahh

Door closed on a dropped pistol right in the beginning of Map02, clickityclickty!

[Corbachu]

How are you doing it? Having videos showing this behavior would help immensely at this point, because me nor Chilly experience the issue. If you can record it, I can try better to isolate it! ^_^

[ryan-sg]

Just re-verified in the last built binary where I thought it was gone and it was still there too, I guess I just was really flukey to not bring it out. In my haste to see the fixed barrel placements (they ARE fixed!) i just turned on noclip to see them real quick, enemies shooting at me hit each other and started it.

So easy way is, -warp 02, then idclip, iddqd, idkfa, rocket launcher out, blow up EVERYTHING and you'll have a lot of it hehe.

[ryan-sg]

I tried to record a video of this issue with my phone in a hurry, mmsing to myself was probably a bad idea as you can barely see ANYTHING. (sideways because i had to use a kleenex box as a phone holder so I could play LOL)

Buut, we want sound, and you can still hear it. You can hear my noisy mechanical keyboard, but right at the end when I've stopped at the red keycard the sound has started and I can hear it through this dinky terrible video :D

http://ryan.slipgate.org/3dge_soundloop.mp4

[Corbachu]

The only thing I can think of at this point are these few commits, which updated the core math functions awhile back by Brendan and another user -- this broken behavior seemed to happen shortly after these were made. Chilly, if you can, look over these and make sure they aren't wrong. .

e8ea9b8

2e07d3a

a4f8a73

901ca31

103dc3a

bdc2d23

[Corbachu]

Also, ryan-sg, it might be wise to replay this with Interpolation off (r_lerp 0 and r_vsync 0) to make sure it's not the interpolation code mucking things up...?

[ryan-sg]

Just checked out r_lerp 0; r_vsync 0 here and it still happens, so it seems interpolation code is not to blame.

I don't have time right now, but I can take a stab at reverting those commits you posted above one at a time to see if they help. (Actually, might try at first by reverting ALL, then adding them back one by one...)

[Corbachu]

Also, Ryan,what is your full name so I can properly add you to AUTHORS?

[ryan-sg]

Ryan Freeman, cheers!

[ryan-sg]

sorry guys, i haven't had a chance to look into this just yet, been so busy trying to get another car purchased i haven't even had a moment on the computer for long. I haven't forgot about it!

[Corbachu]

@ryan-sg is this still happening? I can't get it to bug out like this for the life of me >.<