Comments (1)
Hi @mrclay!
Thanks for your suggestions:
- The way I'd do this is using the Theme. We can add a new property to the
fret
object (something likewidth
) and allow customizing it from there. - I think if we make the
width
property from point 1 a function that receives the fret number we can implement variable width frets. - Maybe we can expose a function in
react-guitar
that converts from shorthand to array of numbers and use it...
You can borrow anything from react-guitar, I'd be very happy
Feel free to have a go at implementing any of those things yourself. Otherwise let me know and I'll have a go at the weekend.
Thanks!
from react-guitar.
Related Issues (13)
- Add keyboard shortcuts HOT 2
- should make chords sharable via url HOT 8
- Play on hover HOT 1
- Consider adding react v18 to peerDependencies HOT 3
- Running app fails at createSnapshot HOT 1
- Want to hide finger component HOT 3
- add different tunings HOT 4
- Add support for themes HOT 1
- Allow muted strings HOT 1
- Add story to show smaller guitars
- Add a chord picker HOT 1
- Add tuning picker with custom input support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-guitar.