GithubHelp home page GithubHelp logo

Comments (3)

davidjwbbc avatar davidjwbbc commented on September 14, 2024 1

The location is due to the rt-common-shared submodule only having example files which were moved from the docs directory in this repository to rt-common-shared. So preserving the examples under docs seemed sensible. The rt-common-shared submodule now contains the helper scripts too, whiich means the location of this submodule should probably move out of the docs directory.

I would suggest:

  1. Move docs/rt-common-shared to external/rt-commonm-shared
  2. Modify pyproject.toml to distribute the examples from external/rt-common-shared/5gms/examples/* with the other docs.
  3. Add external/rt-common-shared as a recursive include in the MANIFEST.in
  4. Make build_scripts/generate_openapi use the common script from external/rt-common-shared/5gms/scripts/generate_openapi.
  5. Rename build_scripts/generate_openapi to build_scripts/generate_5gms_as_openapi to avoid confusion between the two scripts.
  6. Modify build_scripts/backend.py to use the renamed script.

from rt-5gms-application-server.

rjb1000 avatar rjb1000 commented on September 14, 2024

Seems a bit unintuitive to import the submodule under docs, @davidjwbbc.

from rt-5gms-application-server.

rjb1000 avatar rjb1000 commented on September 14, 2024

Sounds like a good plan, @davidjwbbc.

from rt-5gms-application-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.