Comments (3)
@roneli I'm not quite clear on this problem. Can you please take a look?
from gqlgen.
Hi,
I am implemented #2850, I didn't break the original interface as I didn't want it to cause issues with backwards compatability. Basically, I concluded that not passing if it exists doesn't allow the implementer to decide / modify in future runs.
@StevenACoffman I can modify the interface to also include the prevDecl (will be empty if it was never declared etc') so the resolver implementor can decide if to change it or not. Question is are we okay with breaking the interface? I can make a new one that also accepts previous and switch case based on the provided implementation to keep backwards compatibility.
I'll dive deeper into the code and upload a proposed interface tomorrow.
from gqlgen.
Hi, @tsingsun
I created a PR that gives the resolver implementor the previous method body, it will be empty if no previous body was created before.
It does break the interface, but I would assume its a minor inconvenience for the anyone who uses this interface to update.
@StevenACoffman would love for any comments on the interface change
from gqlgen.
Related Issues (20)
- What is the best way to pass variables between query and response object field resolver ?
- unrecognized import path "sourcegraph.com/sourcegraph/appdash-data": reading https://sourcegraph.com/sourcegraph/appdash-data?go-get=***: 404 Not Found HOT 9
- Mutation resolver code generation
- Code generation broken for federated multi-key, multi-entity types HOT 1
- [Bug] Altair introspect query error
- gqlgen v0.17.42 breaks / incompatible with gqlgenc vv0.16.0 HOT 17
- Use go.work and workspaces
- Pass error code in Websocket InitFunc
- @policy directive is not recognized while loading the schema to generate code HOT 2
- Resource exhaustion when handling of crafted queries
- [Proposal] Support embeding via extraFields attribute
- Generation error on Go 1.22.0 HOT 13
- Finding resolver for Entity: type not found HOT 2
- Fail to upload file HOT 4
- How to transfer cookies from the generated handler
- How to skip gqlgen to generate resolver for specific field
- Response is not match embedded struct already have json tag
- Test client error while deserializing Time scalar HOT 1
- panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x642ede] HOT 2
- interface conversion: interface {} is []interface {}, not map[string]interface {} HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gqlgen.