r_0, r_in estimate and julia_source functionality?

casv2

Do we still need these functions as the new defaults in ACE1pack already take care of this? @bernstei

bernstei

I guess we don't have any use for them now, and we can always revive it from git history. Maybe move them to some sort of Attic directory, so we remember it exists? I can do that.

casv2

OK, sounds good

casv2

Wait same goes for the julia_source basis interface? Maybe we can "hardcode" the current basis back in and just change smoothness priors. All heuristics go into ACE1pack. We'd change heuristics there and update our `tomls` in this repo separately.

bernstei

I really like being able to experiment with a new basis just by passing julia source, and it's a trivial amount of code complexity in my opinion, so I'd rather leave that in.

casv2

Sure, let's keep it

bernstei

I'll do this once your PR updating the basis is merged and we no longer need that function in the tests.

casv2

Done in #4