Managed Elements Get Moved Relative To Comments & Other Unmanaged Elements

#1 · open · 0 comments

View on GitHub ↗

BellCubeDev

<table> <tr> <th> Before </th> <th> After </th> </tr> <tr> <td> ```xml <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://qconsulting.ca/fo3/ModConfig5.0.xsd"> <moduleName>Banana Mod</moduleName> <moduleImage path="images\decorative\BANANA.jpg" /> <requiredInstallFiles> <file source="" /> <folder source="" /> </requiredInstallFiles> <conditionalFileInstalls> <patterns> <pattern> <dependencies /> <files> <file source="" /> <folder source="" /> </files> </pattern> </patterns> </conditionalFileInstalls> <!-- comment --> </config> ``` </td><td> ```xml <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://qconsulting.ca/fo3/ModConfig5.0.xsd"> <moduleName>Banana Mod</moduleName> <moduleImage path="images\decorative\BANANA.jpg" /> <!-- comment --> <requiredInstallFiles> <file source="" /> <folder source="" /> </requiredInstallFiles> <conditionalFileInstalls> <patterns> <pattern> <dependencies /> <files> <file source="" /> <folder source="" /> </files> </pattern> </patterns> </conditionalFileInstalls> </config> ``` </td></tr> <tr> <th> Diff </th> </tr> <tr><td> ```diff <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://qconsulting.ca/fo3/ModConfig5.0.xsd"> <moduleName>Banana Mod</moduleName> <moduleImage path="images\decorative\BANANA.jpg" /> + <!-- comment --> <requiredInstallFiles> <file source="" /> <folder source="" /> </requiredInstallFiles> <conditionalFileInstalls> <patterns> <pattern> <dependencies /> <files> <file source="" /> <folder source="" /> </files> </pattern> </patterns> </conditionalFileInstalls> - <!-- comment --> </config> ``` </td></tr> </table> Tasks: * [ ] Determine how to reorder elements when reordering is required * [ ] Implement this in every place where multiple elements are handled * [ ] Write tests to ensure this issue doesn't appear in the future

Comments