Hi,
Thanks for this awesome repo.
### Possible issue 1
You are not specifying the postgis version while installing it
https://github.com/GUI/postgis-docker/blob/940d4e05b56608259395b66db5e8c07d8fb551a5/12/postgis-3/Dockerfile#L11
I found other maintainers specifying the version, see
https://github.com/appropriate/docker-postgis/blob/c7e727fcec998f7bab4ebbb13a03db85c85f4f37/11-2.5/Dockerfile#L12
Do you think `apt` will install the exact version without specifying?
### Suggestion 1
Can you please add a `MAINTAINER` label to dockerfile.
Read the docs here
https://docs.docker.com/engine/reference/builder/#maintainer-deprecated
You can add more labels if you want, example
```
LABEL maintainer="your-name-<your-email>"
LABEL github="https://github.com/GUI/postgis-docker"
```
### Suggestion 2
I am not a docker expert but i dont see a `.dockerignore` anywhere in repo,.
I am not sure if it would make any difference.
### Suggestion 3
Please add a `LICENSE` file
Thanks
@ankurk91: Thanks for the suggestions!
- Regarding the version of the `postgis` package, the lack of version was actually intentional. The [pgdg repo](https://wiki.postgresql.org/wiki/Apt), which provides all these official packages, only provides a `postgis` package that's pinned to the most recent release. In other words, despite there being packages like `postgresql-9.6-postgis-2.4`, there is no published version of the postgis package for the PostGIS 2.4 release. So while appropriate/docker-postgis does pin this version, I think that only works because the images were built at the time the packages were released. I don't think you could actually build that linked Dockerfile anymore, since the `2.5.2+dfsg-1~exp1.pgdg90+1` version of the `postgis` package no longer exists in the pgdg repo.
I'm not entirely sure how correct installing the latest version of the `postgis` package is, but this package only provides a few extra command-line tools, so it doesn't actually seem to be tied to the postgis functionality installed on the server. The postgis package provides the `pgsql2shp`, `raster2pgsql`, and `shp2pgsql`, so I'm wondering if they don't keep old releases of this around since it's assumed those extra utilities are compatible with any version. In any case, definitely let me know if you run into issues with these tools, but I don't think this should affect the core PostGIS functionality. We could also omit this package entirely if it ends up causing more trouble than it's worth.
- Thanks for the note about labels. Since I'm terrible at responding to e-mails, I'm not sure it's worth putting that in the dockerfile, but I do like the idea of linking to github. I've done that using the [opencontainer suggested annotations](https://github.com/opencontainers/image-spec/blob/master/annotations.md). But let me know if there's some other reason you think the maintainer label should be added.
- Since we're not copying any files into the docker builds, I don't think a `.dockerignore` should be necessary.
- Good catch on the license. Added!
Thanks for the feedback, and glad you're finding these images useful!
* I have verified the PostGIS version with `SELECT PostGIS_Lib_Version()` on `nickblah/postgis:11-postgis-2.5.3` and it returns expected version (2.5.3).
* The labels you added is good enough.
Thanks.