.SRCINFO file of AUR repository uses Windows-style line-endings

#34 · closed · 5 comments

View on GitHub ↗

frazar

Hi, and thank you for maintaining this package! I would like to report that [a recent commit](https://aur.archlinux.org/cgit/aur.git/commit/?h=c%2b%2butilities&id=59b4babd977cd6ab356164fc980185b1d82da050) to the c++utilities.git repository on AUR changed the line endings of the `.SRCINFO` file from Unix-style (`\n`) to DOS-style (`\r\n`). Issue reproduction: ```bash git clone -q https://aur.archlinux.org/c++utilities.git cd c++utilities git switch -dq 59b4babd977cd6ab356164fc980185b1d82da050 # The commit introducing the change file .SRCINFO # Check file info git switch -dq 59b4babd977cd6ab356164fc980185b1d82da050^ # The commit before the change file .SRCINFO # Check file info ``` which prints ``` .SRCINFO: ASCII text, with CRLF line terminators .SRCINFO: ASCII text ``` I don't know if the change was intended, but unfortunately breaks some of the AUR utilities like `aurutils` ([see upstream bug report](https://github.com/aurutils/aurutils/issues/1203)).

Comments

Martchus

I'm wondering why this happened now. This was definitely not an intended change. The script I'm using is basically just doing the following after copying the PKGBUILD from my PKGBUILDs repo checkout to the AUR repo checkout: ``` makepkg --printsrcinfo > .SRCINFO git add . .SRCINFO git commit … ```

Martchus

I now pushed a Unix-style version again converting the `.SRCINFO` files via `dos2unix`. I also re-ran my update script on my server and workstation (not sure from where I did the last round of updates) and on both machines I got Unix-style line endings. Perhaps I was using my openSUSE laptop directly (instead of logging from there into my server like I normally do) where my update script would have automatically resorted to invoking `makepkg` via `podman` and an Arch Linux container. I can test this when I'm on that openSUSE laptop again. Otherwise I have no idea why it used Windows-style line endings the other time.

Martchus

I guess I can nevertheless close this for now.

Martchus

Looks like this was indeed due using makepkg via podman, see the commit referenced by GitHub.

frazar

Thank you very much for your investigation and the quick action. I can confirm that the compilation issue does not reproduce anymore.