Tests fail

yurivict

``` [ 50% 1/2] /usr/local/libexec/ccache/c++ -DCPP_UTILITIES_USE_NATIVE_FILE_BUFFER -I/usr/ports/multimedia/tagparser/work/tagparser-12.0.0 -I/usr/ports/multimedia/tagparser/work/.build -I/usr/ports/multimedia/tagparser/work/tagparser-12.0.0/.. -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -I/usr/ports/multimedia/tagparser/work/stage/usr/local/include -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -I/usr/ports/multimedia/tagparser/work/stage/usr/local/include -isystem /usr/local/include -DNDEBUG -std=gnu++17 -fvisibility=hidden -MD -MT CMakeFiles/tagparser_tests.dir/cppunit.cpp.o -MF CMakeFiles/tagparser_tests.dir/cppunit.cpp.o.d -o CMakeFiles/tagparser_tests.dir/cppunit.cpp.o -c /usr/ports/multimedia/tagparser/work/.build/cppunit.cpp [100% 2/2] : && /usr/local/libexec/ccache/c++ -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -I/usr/ports/multimedia/tagparser/work/stage/usr/local/include -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -I/usr/ports/multimedia/tagparser/work/stage/usr/local/include -isystem /usr/local/include -DNDEBUG -fstack-protector-strong CMakeFiles/tagparser_tests.dir/tests/helper.cpp.o CMakeFiles/tagparser_tests.dir/tests/mediafileinfo.cpp.o CMakeFiles/tagparser_tests.dir/tests/overallflac.cpp.o CMakeFiles/tagparser_tests.dir/tests/overallgeneral.cpp.o CMakeFiles/tagparser_tests.dir/tests/overallmkv.cpp.o CMakeFiles/tagparser_tests.dir/tests/overallmp3.cpp.o CMakeFiles/tagparser_tests.dir/tests/overallmp4.cpp.o CMakeFiles/tagparser_tests.dir/tests/overallogg.cpp.o CMakeFiles/tagparser_tests.dir/tests/tagvalue.cpp.o CMakeFiles/tagparser_tests.dir/tests/testfilecheck.cpp.o CMakeFiles/tagparser_tests.dir/tests/utils.cpp.o CMakeFiles/tagparser_tests.dir/doc/example.cpp.o CMakeFiles/tagparser_tests.dir/cppunit.cpp.o -o tagparser_tests -L/usr/local/lib -Wl,-rpath,/usr/local/lib:/usr/ports/multimedia/tagparser/work/.build /usr/lib/libcrypto.so -lcppunit libtagparser.so.12.0.0 /usr/lib/libz.so /usr/local/lib/libc++utilities.so.5.24.0 && : [ 0% 1/1] cd /usr/ports/multimedia/tagparser/work/.build && /usr/local/bin/ctest --force-new-ctest-process Test project /usr/ports/multimedia/tagparser/work/.build Start 1: tagparser_run_tests 1/1 Test #1: tagparser_run_tests ..............***Failed 0.01 sec /usr/ports/multimedia/tagparser/work/tagparser-12.0.0/testfiles/ /usr/ports/multimedia/tagparser/work/tagparser-12.0.0/testfiles/ ./testfiles/ Directory used to store working copies: /usr/ports/multimedia/tagparser/work/.build/testworkingdir/ Executing test cases ... ....E. MP4 parser E. MP3 parser E. OGG parser E. FLAC parser E. Matroska parser E. MP4 maker - testmode 0: tags after data E. MP3 maker - testmode 0: ID3v2 only E. OGG maker - testmode 0: modifying tag E. FLAC maker - testmode 0: modifying tag E. Matroska maker - testmode 0: tags after data, index after data E. Matroska maker - rewrite file with nested tags E.........ld-elf.so.1: /usr/local/lib/libc++utilities.so.5: Undefined symbol "libiconv_open" 0% tests passed, 1 tests failed out of 1 Total Test time (real) = 0.01 sec The following tests FAILED: 1 - tagparser_run_tests (Failed) Errors while running CTest FAILED: CMakeFiles/test.util ``` Version: 12.0.0 FreeBSD 13.2

Martchus

It looks like your build environment is somewhat broken. Normally CMake sets the rpath appropriately for ELF-based platforms. Apparently this doesn't work in your case so libc++utilities cannot find iconv. I have no idea how you set things up and I've never been using FreeBSD myself so I'm sorry but you're on your own. It definitely looks like you have not been following the section "[Building this straight](https://github.com/Martchus/tageditor#building-this-straight)" which would be most appropriate for developing and you have also not been following the packaging examples (at least not very closely). So I'm really wondering what you're trying to achieve here. Note that the tests of tagparser are likely deemed to fail in your environment anyways unless you also download/generate all the required testfiles (e.g. via https://github.com/Martchus/tagparser/blob/master/scripts/download_testfiles.sh). You may be able to run a subset of tests, though. (One can run a subset of tests by invoking `ctest` with the appropriate filter option manually.) In all your tickets you don't state how to reproduce the problem. At a bare minimum it would be good to know what/where libraries are installed in your build environment, what environment variables you set and how you invoked CMake for configuration and build and the logs of these invocations. Admittedly, in this case it likely doesn't make much of a difference because you better figure this out on your own as I am likely not going to spend the effort of replicating your build environment.

stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

yurivict

not stale

Martchus

Ok, so this is still relevant to you. As stated in the last paragraph of my previous comment, this issue is not workable for me. You need to provide more information. Even then I'm likely just being able to give general advice as I don't know the platform you are compiling on/for.

stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Martchus

Closing this for good after not receiving an answer for clarification in month.