Apple Pay: firstname/lastname swapped in authorization request, is this intended?

#415 · open · 1 comments

View on GitHub ↗

smpl-at

Hi PAYONE team, While setting up Apple Pay with plugin version **v7.4.1** (Shopware 6.7), we noticed something in the Apple Pay authorization enricher and wanted to check whether it's intentional: https://github.com/PAYONE-GmbH/shopware-6/blob/v7.4.1/src/Provider/ApplePay/RequestParameter/Enricher/AuthorizeRequestParameterEnricher.php#L98-L99 ```php 'lastname' => $billingAddress->getFirstName(), 'firstname' => $billingAddress->getLastName(), ``` The shared `CustomerRequestParameterBuilder` maps these the other way round: https://github.com/PAYONE-GmbH/shopware-6/blob/v7.4.1/src/Payone/RequestParameter/Builder/CustomerRequestParameterBuilder.php#L64-L65 ```php 'firstname' => $billingAddress->getFirstName(), 'lastname' => $billingAddress->getLastName(), ``` Thanks!

Comments

janteuber

Hello @smpl-at , Thanks for reporting this. I have forwarded it for review and will get back to you here once there is a result or a PR available.