Comments (8)
Hi!
Great that you contribute, I am traveling until tomorrow and can only look into it tomorrow.
I learned a couple of weeks ago that now there is a much faster way to get the coverage and was postponing to implement the change into xcresultparser... Procrastinating again :-)
Now I will definitely take the time to collaborate again asap!
from xcresultparser.
@hisaac Ahhhh ok I glanced over the MR but assumed it didn't solve the actual issue which is in the file CoverageConvertor.swift
because there were no changes to it. I'll checkout the PR to see if it solves the problem!
As for how I use the execution count ("hits"); I do all my work with GitLab and they offer test coverage visualisation in their MRs. Using this allows me to quickly hover over covered lines to see how many times a piece of code has been 'hit', this has been handy to easily check that a piece of code has been tested a suitable amount of times.
For example, a function that verifies if an email is valid or not, testing it once would technically mean it's covered (and GitLab will highlight anything >=1 hits in green to show its been covered), but I would still flag it up that it has not been tested enough.
So the issue is a little annoying for code that has 100 hits because xcresultparser just says its only has 1 hit.
from xcresultparser.
Ah gotcha, yeah perhaps the solution you have in mind is more effective. Never hurts to open a PR with ideas. 😊
from xcresultparser.
Think I figured the issue out! Will make a PR soon!
from xcresultparser.
There's actually an open PR from @maxwell-legrand that will fix that issue (among some other things) #25
from xcresultparser.
Just out of curiosity, how are you using the execution count? We were just discussing yesterday how someone might use that value.
from xcresultparser.
And that's a cool feature of GitLab! I wasn't aware of that.
from xcresultparser.
Yeah it is pretty nifty! Shame that GitHub doesn't have it!
from xcresultparser.
Related Issues (18)
- Any chance of getting xcresultparser on brew? HOT 2
- Ignore directories/files? HOT 5
- Binaries attached to releases HOT 15
- "--project-root" seems to be case sensitive when used while generating coverage HOT 5
- Json format output HOT 4
- Skipped tests shows as failed in txt results HOT 5
- Wrong calculation of failed tests in txt results HOT 2
- Corrupted data in txt results if run UI tests simultaneously on two devices HOT 5
- fullpath is not shown in xml HOT 10
- Why need to get the dtd file by visiting http://cobertura.sourceforge.net ? HOT 2
- Markdown formatting on github will display `<span>` tags HOT 1
- `xcresultparser` errors out with code 133 when executed HOT 14
- Release: 1.6.0 HOT 7
- Unable to find bundle named Xcresultparser_XcresultparserLib HOT 16
- Install of 1.6.2 through Homebrew is failing HOT 11
- [FEATURE REQUEST] Extend JUnit XML output to include additional attributes HOT 3
- DTD Download Failure HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xcresultparser.