GithubHelp home page GithubHelp logo

Comments (3)

AhmedBaset avatar AhmedBaset commented on May 13, 2024 2

Salam @KarimRedaHassan Thanks for reporting the issue. It should be fixed now by #7 Please try again and let me know if it didn't.

from hadith-json.

KarimRedaHassan avatar KarimRedaHassan commented on May 13, 2024

I didn't try your modifications yet but I have found the issue and solved it. Actually, there was no missing chapters but the chapters' sorting in the book is inaccurate because it merges the files from by_chapters folder based on the files' names and the naming of those files is 1, 2, 3, ... , 20, 21, ... which causes the issue as when you sort these numbers you will find the actual sort is 1, 10, 11, .... , 2, 20, 21, ... , 3, 31, ...
So, the solution was to make the file naming follows a 2 digits pattern such as 01, 02, 03, ....

from hadith-json.

AhmedBaset avatar AhmedBaset commented on May 13, 2024

It was solved

https://github.com/A7med3bdulBaset/hadith-json/blob/ca32fd72aa16eeeb9a819c80bb65c9e78766532d/src/index.ts#L154-L159
// the previous snippet sorts files by {n}.json

I agree with you on the file naming. Actually when I looked into the code yesterday I found too much space for improvements
https://github.com/A7med3bdulBaset/hadith-json/blob/ca32fd72aa16eeeb9a819c80bb65c9e78766532d/README.md?plain=1#L120

from hadith-json.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.