Handling of SIGPIPE (lock screen) about react-native-exception-handler

[pesterhazy]

Just wanted to drop a note that 2.7.0 has fixed the issue for us - many thanks!

[a7ul]

Ok. How about this . So currently to customise native Exception handling we have a function mentioned at this part of the README
Modifying iOS Native Exception handler UI (NATIVE CODE HAS TO BE WRITTEN) recommended that you do this in XCode

Maybe we can add a extra parameter to the block that is passed to
ReactNativeExceptionHandler replaceNativeExceptionHandlerBlock

Currently it takes a block that accepts two parameters replaceNativeExceptionHandlerBlock:^(NSException *exception, NSString *readeableException)
Maybe we can add another parameter to it like so

replaceNativeExceptionHandlerBlock:^(NSException *exception, NSString *readeableException, int signal){
if(signal === SIGPIPE){
//ignore and do nothing
}else{
//show popup 
}
}

So If anyone wants to handle/ignore any custom signal, then they can do so inside this callback itself.
So essentially
When SIGPIPE occurs the custom block specified by the user will be called and they can choose to handle/ignore it safely.

What do you say ? @pesterhazy

[pesterhazy]

Sounds like a good general solution. Two comments:

• It would be great if there was a way to call the original error handler, so we don't have to copy and paste the UIAlertController call (not necessary of course, I'm just reluctant to copy and paste too much)
• Perhaps it would be a good default to ignore SIGPIPE, which can be considered an informational signal. For iOS apps, IMO it usually doesn't make sense to crash as a response to it

For reference, here are a few links discussing SIGPIPE on iOS:

• https://stackoverflow.com/questions/32197319/network-code-stopping-with-sigpipe/32197674#32197674
• golang/go#17393
• mumble-voip/mumblekit#47 (comment)

[a7ul]

Okay . So I think i will remove the SIGPIPE handler all together. What do you think ?

[pesterhazy]

Perfect!

…

On Thu, Jan 4, 2018 at 2:07 PM, Atul ***@***.***> wrote: Okay . So I think i will remove the SIGPIPE handler all together. What do you think ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGfWJDjD_M57MfgjMIxJE_zjPXX3vkcks5tHM0ogaJpZM4RSKmf> .

[pesterhazy]

To add one more data point in support of remove the SIGPIPE handler, attaching a debugger it looks like in our app the SIGPIPE occurs within UIKit, so this probably affects a lot of people, not just those with native code added.

[a7ul]

Release v2.7.0 - It has the fix for this.
Thanks @pesterhazy