setNativeExceptionHandler is not working properly about react-native-exception-handler

[a7ul]

Hi @Paradox-AT . The example code at https://github.com/master-atul/react-native-exception-handler-example seems to work as expected. Can you please recheck your configuration or can you see what you have missed from the example.

[Paradox-AT]

Hello @master-atul, I was trying to use that example but while building I am getting the following error:

:rn-test-exception-handler:compileReleaseJavaWithJavac
:rn-test-exception-handler:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have
changed, no previous execution, etc.).
C:\Users\aayush.thakur\Desktop\react-native-exception-handler-example\node_modules\rn-test-exception-handler\android\src\main\java\com\masteratul\rn\testexception\RnTestExceptionHandlerPackage.java:19: error: method does not override or implement a method from a supertype
    @Override
    ^
1 error
:rn-test-exception-handler:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':rn-test-exception-handler:compileReleaseJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

So I figured that there is some problem with the test package so I created my own package for throwing the exception. But still, it was not working as expected. So I tried digging into your implementation and found that even if I am setting the handler by myself it was not working for me.

It might be a problem with react-native so I also raised an issue there: facebook/react-native#19784

[Paradox-AT]

BTW, this is my dev env conf:

Environment:
OS: Windows 10
Node: 8.11.2
Yarn: 1.6.0
npm: 6.0.0
Watchman: Not Found
Xcode: N/A
Android Studio: Version 3.1.0.0 AI-173.4819257

Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: 0.55.4 => 0.55.4

[a7ul]

Interesting. Seems like the error was in rn-test-exception-handler package. Have fixed the issue. Everything should work normally now. Please install the latest version of rn-test-exception-handler.
PS: The issue was not in the react-native-exception-handler package.

[a7ul]

Take a pull in the example repo
do yarn install
and run it as usual

[a7ul]

If you still face issue. Please re open the issue. Thanks for reporting. !

[Paradox-AT]

After updating the project I am able to build it but still, I am getting the error in those red boxes.

Also, I looked into your code and tried to implement it by myself but still I am having the same issues.

[a7ul]

This is the expected behavior. the rn-test-exception handler when in development mode will throw native errors to red boxes. Only in bundled production mode... the red boxes will be replaced. Can you try it in bundled production mode react-native run-ios --configuration Release

[a7ul]

or react-native run-android --variant=release for android. You ll need to make sure you setup your project with release mode enabled. https://facebook.github.io/react-native/docs/signed-apk-android.html

[a7ul]

I have updated the https://github.com/master-atul/react-native-exception-handler-example to build in production mode. You can check the latest here: https://github.com/master-atul/react-native-exception-handler-example

[Paradox-AT]

So it works in production mode..!

Hey, can you point me to the documentation for the native error handler?
Thanks..!

[a7ul]

Its all there in the README.md of https://github.com/master-atul/react-native-exception-handler/

[Paradox-AT]

I am not talking about the documentation your module, I'm asking about the documentation from where you implemented your module i.e NativeModules.ReactNativeExceptionHandler.setHandlerforNativeException()

[a7ul]

There is no such documentation. Its a simple unhandled exception handler found in Java/android/ios.

[Paradox-AT]

Okay... will look into it. Thanks