Impossible to match error and request about node-rest-client

[aacerox]

Hi

I'm currently working on a solution to your issue. I'll try to return a new "Request" object for each method invocation. That "Request" object will be passed to ConnectManager and will handle error events emitted by each request. So if all works as expected you'll have a errorHandler on returned request object you can use to catch only request specific errors.

Also I'll try to parametrize this solution in options passed to the client, so you can choose to use it or not. something like this

var options ={
 //other options here
  manageRequests:true
}

var client = new Client(options);


//just handle errors
client.get(.. params..).on('error', function(err){
//catch error here
console.error(err); });

//use request object returned by method

var request = client.get(... params ...);

request.on('error',function(err){
 console.error(err);
};

//I'll probably add some properties to request object not just error handler

console.log(request.time);// or any other "awesome" properties ;)

[mast]

Solution seems very good! I'm waiting for it.
Thank you in advance!

[TimNZ]

I know this would break existing code, but really you should follow the standard function(err,...) approach for callbacks.

Perhaps just add an option 'errInCallback' and if true (default = false), then callback is (err, data, response)

I'm researching rest clients instead of rolling my own and so far yours looks great apart from the error handling.

Perhaps I'll fork and have a stab myself in the meantime.

[aacerox]

Hi

first of all sorry for the delay but I've been quite busy at work lately, but finally I've a fix for bug #5. Solution is like the one I explained in previous messages but with one main difference: there's no need to declare any property on client options, now each method request returns a request object with specific request information and error handler.

You have the details on readme.md but here you have an example

var req=client.get(.. params..);

console.log('request options', req.options);

req.on('error',function(err){
 console.log('request property on error object', err.request);
 console.log('request options', err.request.options);
});

TimNZ I've tried to follow node.js standards for handling error events , with the advantage of no breaking any existing code and maintain backward compatibility, hope you like the solution.

Thank you all.

[mast]

@aacerox Thank you for the fix! It's appreciated!