GithubHelp home page GithubHelp logo

Comments (5)

fakeid30 avatar fakeid30 commented on June 10, 2024

@cullzie what do you think?

from automatic-udemy-course-enroller-get-paid-udemy-courses-for-free.

baseplate-admin avatar baseplate-admin commented on June 10, 2024

This is not a good take on this issue as cloudscraper internally uses requests and requests-toolbelt and so including httpx will introduce yet another HTTP Client library ( which we are trying to avoid )

from automatic-udemy-course-enroller-get-paid-udemy-courses-for-free.

baseplate-admin avatar baseplate-admin commented on June 10, 2024

I have another proposal to move everything to requests.

@cullzie what do you think ?

from automatic-udemy-course-enroller-get-paid-udemy-courses-for-free.

cullzie avatar cullzie commented on June 10, 2024

Hey @baseplate-admin,
The cloudscraper dependency is the only reason we have both requests and aiohttp.
I would be happy to have a look at your proposal on this

from automatic-udemy-course-enroller-get-paid-udemy-courses-for-free.

baseplate-admin avatar baseplate-admin commented on June 10, 2024

It's been a couple of months.

So here's my take on this issue,

It's tiresome to wait for aiohttp to bump their dependencies every major python upgrade.

So, here are my proposals :

  1. My first proposal is to move everything to httpx. It has a synchronous ( and on demand asynchronous ) api that would suffice our needs pretty well.

  2. My second proposal is that, we dont use aiohttp and use requests for everything. The requests ecosystem is amazing and faster-cpython project willl only increase the performance of requests

from automatic-udemy-course-enroller-get-paid-udemy-courses-for-free.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.