Comments (8)
Hello,
Thank you for your answer.
What I meant was, when I:
- Create a new project in Visual Studio 2017
- Then add the ImmutableObjectGraph NuGet package
- Then create a class with the attribute [GenerateImmutable]
- Then compile
I get the error above.
The commit you did only change test projects so I don't think it can fix my issue.
Note that I have both 2015 and 2017 installed.
from immutableobjectgraph.
Based on the error you saw, I believe I've fixed the missing build dependency on a machine with only VS2017 installed.
Regarding the trouble you're seeing with CodeGeneration.Roslyn, its latest version has some issues as I'm trying hard to get that to work on .NET Framework as well as CoreCLR on both Windows and Linux, which is evidently a really hard balancing act.
from immutableobjectgraph.
Ah, I think I misunderstood your issue and thought you were building this repo and getting the break there.
from immutableobjectgraph.
The problem still persists.
where is the dependancy on Microsoft.Build.Utilities.Core, Version=14.0.0.0 coming from?
i had hoped that recreating CodeGeneration.Roslyn.Tasks with VS2017 is sufficient but that's not the case.
@AArnott have you considered creating a fork of CodeGeneration.Roslyn and ImmutableObjectGraph depending on .netStandard only? this could get us rid of all the portable stuff hopefully reducing complexity and increasing upgradeability. (because the targetframework problem mentioned here occurs when i try to build ImmutableObjectGraph, too. but it doesn't seem to be solved so easy...)
from immutableobjectgraph.
No MSBuild Task can depend on .NETStandard only due to MSBuild on the .NET Framework not guaranteeing that .NET Standard façade assemblies are present at runtime.
I believe you're seeing this because you don't have MSBuild 14 installed. But I see that IOG depends on a rather old version of CG.R and perhaps updating it all properly from within the IOG repo will resolve the issue. I'll give it a try.
from immutableobjectgraph.
Fixed by 2d6a1b8
from immutableobjectgraph.
Thanks. Was it much manual work? Your commit included many changes to the Assert methods you used, can those be filtered out?
from immutableobjectgraph.
Yes it was a lot of work. It included package dependency updates like xunit that brought build warnings that the assertion fixes addressed.
While it could possibly be more minimal. Of a change, why would that be interesting?
from immutableobjectgraph.
Related Issues (20)
- Fix test failures HOT 1
- Emit PureAttribute on all pure members HOT 1
- Analyzer to flag invocations of [Pure] methods as an ExpressionStatementSyntax HOT 2
- Self-referencing collections shouldn't have to have "using IOG;"
- Implement IEqualityComparer<T> for immutable types
- `DefineWithMethodsPerProperty = true` fails when source doc has no using for ImmutableObjectGraph
- Empty/IsEmpty properties HOT 7
- Implement Visitor pattern for Walkers and Re-writers
- Bi-direction relationships a'la Roslyn Red/Green trees HOT 3
- Trying to upgrade from 1.1.7 HOT 7
- Document if capable generating readonly struct HOT 2
- Build fails once .NET Core SDK 3 is installed HOT 1
- Missing using ImmutableObjectGraph when model has ImmutableList<T> fields HOT 1
- Can I target .NET FW 4.5 HOT 1
- Property-specific With methods fail when using `ReadOnlyMemory<byte>` fields
- Use <inheritdoc> in many more places to get docs copied
- .Net Core support HOT 1
- Use in .Net Core project HOT 2
- Adding deconstruction
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from immutableobjectgraph.