GithubHelp home page GithubHelp logo

Comments (6)

kumkee avatar kumkee commented on June 15, 2024

@aaronpowell, I'd like to contribute and make identity-based connections a reality if no one has the time. To achieve that, I'll need to communicate with you and/or other authors of the library first. This is because it is going to change a major type, ConnectionOperation and I don't want to waste time onto the wrong direction.

My idea for the implementation is to add a new boolean member WithIdenty to type ConnectionOperation. When it is false the type would work as what it does now. When it is true, it is connecting using endpoint and the identity provided by DefaultAzureCredential().

The next step after DefaultAzureCredential() would be adding an option for the user to specify which identity to use with DefaultAzureCredentialOptions.

@aaronpowell, please let me know what you think especially whether these implementation ideas are too intrusive to the existing codebase.

Thank you.

from fsharp.cosmosdb.

aaronpowell avatar aaronpowell commented on June 15, 2024

The change is probably not that huge, it'd just be adding another two properties to the ConnectionOperation type and having an expanded match on what the connection mode should be when creating the CosmosClient.

In the future, maybe it'd be better to refactor to use the AzureKeyCredential but I'd have to check to ensure the constructor for CosmosClient works with it.

Submit a PR and I'll review and we can iterate as needed.

from fsharp.cosmosdb.

kumkee avatar kumkee commented on June 15, 2024

Submit a PR and I'll review and we can iterate as needed.

Hi @aaronpowell,

  1. CI build process failed. I see this happens to your one other GitHub Action build attempt. Have you found out why it failed?
  2. Can you give me some light on how to test or install the locally built library?

from fsharp.cosmosdb.

fwaris avatar fwaris commented on June 15, 2024

looking for the same capability

I tried to build it myself also but I think the build tooling needs to be updated, first

from fsharp.cosmosdb.

kumkee avatar kumkee commented on June 15, 2024

looking for the same capability

I tried to build it myself also but I think the build tooling needs to be updated, first

@fwaris, if you don't use the Analyzer, you can use my build for now.

from fsharp.cosmosdb.

fwaris avatar fwaris commented on June 15, 2024

ok great. thanks!

BTW I was able to build by updating dotnet tools and using a global.json for .Net 6

from fsharp.cosmosdb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.