GithubHelp home page GithubHelp logo

Comments (2)

sendra avatar sendra commented on June 8, 2024

I would not put it in user, as the incentives are per reserve. I would create another separate method specific to calculate the incentives of a reserve.

The incentives part regarding the user. its only to calculate the reward that a user has, so its completely different than the reserve incentive api.

In my opinion, i think that doing a helper specific for this is the way to go. In fact it could also have methods for the user reward calculation, as i think this should also be extracted, as if the network does not have incentives, it doesnt make sense for the user to calculate its rewards

from aave-utilities.

joshstevens19 avatar joshstevens19 commented on June 8, 2024

@aschmidt20 once PR above is done you can use that in your user reserve one

from aave-utilities.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.