GithubHelp home page GithubHelp logo

Comments (6)

The-3D avatar The-3D commented on August 16, 2024 1

also the button clearly says "approve to continue", it is pretty clear to me to be honest

from interface.

foodaka avatar foodaka commented on August 16, 2024

personally i agree with this, having the two steps makes it more clear the total flow for the user. i preferred the small -> we had in the initial designs

from interface.

iamanastasia avatar iamanastasia commented on August 16, 2024

I feel like it's the matter of preference.

We've referenced Uniswap and Zapper here, to stay consistent, at least externally.
Adding stepper is not easy in our case, because number of steps is different for every transaction. Besides it's just 2 steps = 2 buttons. And initial idea of changing tx flow was to simplify it, and remove steps.

Let's get more feedback here, to see how easy/difficult these steps are.

from interface.

sendra avatar sendra commented on August 16, 2024

Maybe we could add the number on the button, like:
1 - Approve to continue
2 - Supply USDT
And when there is no approval just show supply USDT

With that and the disabled supply when button 1 is not done it should be clear enough that you need to do both

(I think though that its not needed. that showing both buttons is enough)

from interface.

The-3D avatar The-3D commented on August 16, 2024

i see this two buttons pattern for approvals everywhere (uniswap, 1inch, paraswap, compound just to mention a few) and to be honest I don't feel like its unclear, most users are used to it
to me its clear enough if we don't do anything, if we want to do something the less invasive the better
maybe what @sendra proposed can be a good middle ground

from interface.

foodaka avatar foodaka commented on August 16, 2024

As per feedback closing out

from interface.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.