Authenticated Request about go-http-auth

[ralfr]

I guess you try to address my problem with the wrapped.go example, however, I'm getting the following error:

the runtime process gave a bad HTTP response: ''

[abbot]

This was a design decision. http.Request does not have a good place to pass authentication information, so it can't be used, and this also does not allow to use http.HandlerFunc with authenticated requests passing authentication information. If you are not interested in authentication information, use JustCheck wrapper as shown in wrapped.go example. Please reopen this ticket if wrapped.go example does not work as expected.

[bamarni]

Would you accept a PR with a handler similar to JustCheck except that it takes a standard http handler func? It should be possible to put the username in the request context since go 1.7 (https://golang.org/doc/go1.7#context).

[abbot]

I guess, it would be a variation of https://github.com/abbot/go-http-auth/blob/master/examples/context.go, right?

Something like

func authenticatedHandler(a auth.AuthenticatorInterface, h http.Handler) http.Handler {
    return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
        h.ServeHTTP(w, r.WithContext(a.NewContext(r.Context(), r)))
    })
}

(didn't actually test this code)

Can you point at your code?

[bamarni]

I haven't implemented it yet, but your snippet looks fine. Do you suggest that we create this handler func ourself in our projects, or that this package provides it as a helper?

It seems very similar to JustCheck excepts it sets it in the request context rather than a HTTP header.