GithubHelp home page GithubHelp logo

Comments (5)

abhijit-hota avatar abhijit-hota commented on June 27, 2024 1

Always wanted to contribute to Abell! Now that Hacktoberfest's here, I don't see any reason not to. I just forked the repo. Will look into the codebase and tell if I can take this. =)

P.S. I'm not claiming the issue yet. If anyone is ready to work on it, you can assign it to them!

from abell.

saurabhdaware avatar saurabhdaware commented on June 27, 2024

abelljs/abell-renderer#26 Needs to fixed before we work on this

from abell.

saurabhdaware avatar saurabhdaware commented on June 27, 2024

abelljs/abell-renderer#26 is fixed now.

This is the file you would want to make changes in:
https://github.com/abelljs/abell/blob/main/src/utils/abell-bundler.js#L119

from abell.

saurabhdaware avatar saurabhdaware commented on June 27, 2024

Will start working on this from tomorrow

from abell.

saurabhdaware avatar saurabhdaware commented on June 27, 2024

Ohh I just realized this won't be possible for case like this:

If there is condition like this:
Comp1.abell

<AbellComponent>
<!-- ... -->
<script>
</script>
</AbellComponent>

Comp2.abell

<AbellComponent>
<!-- ... -->
<script type="module">
</script>
</AbellComponent>

In this case, both the scripts will go into same file. According to Comp2.abell, this file now should be loaded as a module but according to Comp1.abell, this file is normal javascript file. This will add overall confusion on which behavior is given more priority so closing this issue for now. I'll reopen this if I could think of something.

from abell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.