GithubHelp home page GithubHelp logo

Comments (3)

cerveada avatar cerveada commented on June 20, 2024 2

Another idea that could help with this is to split tests and test coverage in separated actions.

  • Tests don't need the write permission at all and can happily run using pull_request
  • Test coverage require the permission, but even if it fails, we can still asses the amount of new untested code easily. Adding to that - external PRs are usually small, so it's even less of a problem.

from abris.

kevinwallimann avatar kevinwallimann commented on June 20, 2024

pull_request_target doesn't work like we think. It "runs in the context of the base of the pull request", so it doesn't actually run with the changes from the pull request. It may be useful for tasks like auto-labeling issues, but not to run the build of the PR. It is not a drop-in replacement for pull_request

from abris.

cerveada avatar cerveada commented on June 20, 2024

In #339 we reverted to using pull_request and separated the workflows for tests and test coverage.

from abris.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.