GithubHelp home page GithubHelp logo

Comments (2)

aweits avatar aweits commented on June 8, 2024

As a clarification, the primary issue here is that when nvcc calls the c++ preprocessor for .cu files, arm_neon.h gets included and that brings along definitions of types that only the respective c++ compiler will understand. nvcc then calls cudafe++ on the resultant file and errors out. This is confusing and the output might lead folks to misunderstand where the error is originating from. Running nvcc with the --dryrun or --verbose flag will show all the individual steps being run in the background, and incrementally executing these steps allows one to see what's going on.

from abseil-cpp.

aweits avatar aweits commented on June 8, 2024

The above is probably overly broad (!defined(__NVCC__)), and should be scoped to this (!(defined(__NVCC__) && defined(__CUDACC__))) per https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html and https://llvm.org/docs/CompileCudaWithLLVM.html

diff --git a/absl/base/config.h b/absl/base/config.h
index 5fa9f0ef..503a77af 100644
--- a/absl/base/config.h
+++ b/absl/base/config.h
@@ -962,7 +962,7 @@ static_assert(ABSL_INTERNAL_INLINE_NAMESPACE_STR[0] != 'h' ||
 // https://llvm.org/docs/CompileCudaWithLLVM.html#detecting-clang-vs-nvcc-from-code
 #ifdef ABSL_INTERNAL_HAVE_ARM_NEON
 #error ABSL_INTERNAL_HAVE_ARM_NEON cannot be directly set
-#elif defined(__ARM_NEON) && !defined(__CUDA_ARCH__)
+#elif defined(__ARM_NEON) && !(defined(__NVCC__) && defined(__CUDACC__))
 #define ABSL_INTERNAL_HAVE_ARM_NEON 1
 #endif

from abseil-cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.