Comments (6)
I confirm this is a bug. @JeffMboya please take this one.
from magistrala.
@dborovcanin @arvindh123. On further testing with @JeffMboya, there was an oversight which we have caught and the superadmin cannot share a thing between users in different domains. The issue is on unsharing an entity with non exist users. The operation can be done multiple times as per this comment by @WashingtonKK.
Yes , For unhare, the response should be no content
, It doesn't tell you it is removed successfully.
This made like this to avoid finding the entity ids with brut force.
May be we can return 404 instead of no content
from magistrala.
@dborovcanin @arvindh123 I tried to recreate this issue and found that user1
who has relationmember
in domain1
cannot share thing1
which is in domain1
with user2
who has relation member
in domain2
. However, I did realize that super admin can share thing1
with user2
. Is this supposed to be the case i.e super admin sharing thing
between domains?
from magistrala.
@dborovcanin @arvindh123 I tried to recreate this issue and found that
user1
who has relationmember
indomain1
cannot sharething1
which is indomain1
withuser2
who has relationmember
indomain2
. However, I did realize that super admin can sharething1
withuser2
. Is this supposed to be the case i.e super admin sharingthing
between domains?
@JeffMboya No it should not happen if user_2
is not in domain_1
.
from magistrala.
@dborovcanin @arvindh123. On further testing with @JeffMboya, there was an oversight which we have caught and the superadmin cannot share a thing between users in different domains. The issue is on unsharing an entity with non exist users. The operation can be done multiple times as per this comment by @WashingtonKK.
from magistrala.
It doesn't tell you it is removed successfully.
This made like this to avoid finding the entity ids with brut force.
May be we can return 404 instead ofno content
@nyagamunene for unshare operation, the policy is deleted for all users (whether the user is part of magistrala or non-existent/random) by design
from magistrala.
Related Issues (20)
- Improve search for Users, Things, Channels, and Groups
- Feature: New gRPC function to list mutiple users permissions at single request
- Bug: domain creation allowed with nil alias HOT 1
- Bug: Wrong influxdb volume mapping
- Bug: Bootstrap config state could not change, where thing and channel connected before config creation
- Bug: In a bootstrap config with multiple channels, bootstrap state goes to 1, if any one of the channel connect to thing HOT 1
- Feature: Return response other than error for connecting existing connection of thing and channel HOT 1
- Feature: An Endpoint to verify thing channel connection HOT 2
- Feature: Optimization of list groups
- Improve listing and searching requests HOT 1
- Users are able to search other users via identity HOT 1
- Create Docker Compose integration for testing env
- Bug: Update Bootstrap Config State Updates all Configs States
- Feature: Adding Domain to Events HOT 2
- Feature: Add new certificate manager in certs service HOT 5
- Bug: Users with member relation are able to list things that they have not created
- Bug: Fix JaegerURL in readme.md and `cmd/<svc>/main.go`
- Feature: Pass env files to vault scripts
- Add versioned HTTP API
- Feature: Adding Super admin role in authentication response
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magistrala.