GithubHelp home page GithubHelp logo

accesslint.js's People

Contributors

ckundo avatar connormckelvey avatar jaimeiniesta avatar tysongach avatar wyattdanger avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

accesslint.js's Issues

Host in a CDN?

I think this script is an excellent candidate to keep around as a bookmarklet.

Just to try it out I used this:

javascript:(function(){document.body.appendChild(document.createElement('script')).src='https://github.com/accesslint/accesslint.js/releases/download/v1.1.2/accesslint.js';})();

Works great, I get output in console, but would be nice if there was a latest hosted either in a CDN or just on github where I could reference it.

BUG: False alarm for hidden input fields

Background

Hi, this is the maintainer of @staticmanlab, a public GitLab instance for Staticman. I've recently created PR pacollins/hugo-future-imperfect-slim#69 to introduced a new feature to the project (nested Staticman comments).

Problem

The setup of Staticman with reCAPTCHA for a static blog (theme) requires some hidden form fields.

<input hidden name="options[reCaptcha][siteKey]" value="{{ .sitekey }}">
<input hidden name="options[reCaptcha][secret]" value="{{ .encryptedkey }}">
<div class="g-recaptcha" data-sitekey="{{ .sitekey }}"></div>

Despite their invisibility in the rendered page, AccessLint has raised a false alarm for "missing label".

Screenshot from 2019-08-17 14-24-56

Expected behavior

No false alarm for hidden fields.

Remarks

Thanks for your great project. It spotted out a missing image alt in my image tags for Gravatar.

Accesslint keeps trying to change my <h1> to <h3>

I was working on my organization's webpage and made a commit to one of my student's patch when I saw this:

Accesslint has left review comments

The strangest part was that it wanted me to edit my HTML:

- <h1>
+ <h3>

I knew that headings went from most important (h1) to least important (h6)

Does anybody know why this is happening?

Publish to npm

Can we publish accesslint.js to npm? It would be preferable to be able to manage it via npm install than via copying/pasting a built file into a vendor directory.

MutationObserver is registered at require time

In index.js, that the mutation observer is set up at require time rather than after the window.load event has fired. It seems to me that you wouldn't want to report mutations that happen before the full document scan which happens on window load. I'm happy to file a PR for this as well

accesslint.js can grind interaction to a halt on a page with many DOM mutations

I'm trying to get accesslint running on a React page with a lot of DOM mutations happening. What I've noticed is that tons of mutations get registered, then a bunch of axe checks complete, and sometimes the nodes axe is reporting aren't even in the page any more by the time the violations are printed to the console. It also brings the UI to a grinding slow pace.

I am thinking it could be beneficial to have a throttled audit function which only runs on the full document no more than once per second, rather than on every individual mutation. Thoughts on that? I'm happy to prep a PR

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.