Comments (16)
Please assign this to me.
from cicero-ui.
@gsilvamartin are you still working on this?
@irmerk Can I take a shot at this?
from cicero-ui.
The yellow highlighted portions in cicero-ui
locally here:
These are generated from the markdown-transform
, some parts to refer to:
Though that could potentially be overkill because I believe Slate is the one adding the yellow highlighting annotation, which will be in this repo. @dselman any thoughts?
You'll want to run this locally with cicero-ui
linked through npm link
from cicero-ui.
I wasn't able to work on this. You can unassign me for now.
from cicero-ui.
Opening this back up after 6 days stale. @gsilvamartin let me know if you're still working on it and I'll reassign.
from cicero-ui.
@irmerk I am a little confused by this issue.
Variables should have customizable background colors, as well as only having colors in lockText mode.
-
So here, does
Variables
mean the variables in the template as described here https://docs.accordproject.org/docs/spec-template.html#grammar? -
I can see example of variable usage here - https://studio.accordproject.org/. How can I run this locally?
from cicero-ui.
@mbtamuli any progress on this?
from cicero-ui.
Can I take a shot with this ?
from cicero-ui.
@elit-altum Yes but I believe this may need to be moved to cicero-ui
, which is where variables are defined and used. I'll transfer it there and assign you.
from cicero-ui.
@irmerk Could you tell me if there is any prop which can be accessed by the .variable
class to indicate if the lockText
is true or false ?
from cicero-ui.
Not sure I understand the question completely, but you could find lockText
in this function, probably off the editor
.
from cicero-ui.
@irmerk I have made the backgroundColor
property responsive to editor.props.lockText
. It looks something like this :
Contrast of yellow : blue is 9.55
Should I proceed to make a PR?
from cicero-ui.
Yes that works, we can provide more feedback then!
from cicero-ui.
Yes that works, we can provide more feedback then!
from cicero-ui.
This Issue should be Closed 👍
from cicero-ui.
Once #316 is merged this will be closed.
from cicero-ui.
Related Issues (20)
- Conditional Variable is Editable HOT 4
- Beginning of Variables Editable HOT 11
- Delete Icon is not functional currently. HOT 3
- [FEATURE] Add a shortcut list modal HOT 5
- Add Class prop HOT 2
- Netlify Build of Storybook Demo HOT 1
- Slate Migration (v0.57) HOT 1
- If searched template is not found, it should return no result found message HOT 4
- TemplateLibrary: make styles extensible with classes; change to support heterogeneous libraries HOT 6
- extra clickable area of import buttons HOT 2
- Pressing backspace with caret at start of variable allows delete of non variable text HOT 2
- No css for block quote HOT 5
- Storybook packaged as a dependency HOT 3
- Undoing Breaks The Editor HOT 2
- Can apply bold and italics to inline code HOT 3
- Enhance Storybook HOT 1
- Changing conditional text results in wrong text order
- Undoing After deleting values before "." breaks the editor HOT 4
- Storybook for all AP Components HOT 5
- Forward Delete Clause
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cicero-ui.