GithubHelp home page GithubHelp logo

Comments (7)

dselman avatar dselman commented on August 28, 2024

I think wrapping it in the content control is sufficient.

from markdown-transform.

irmerk avatar irmerk commented on August 28, 2024

@K-Kumar-01 does #432 close this Issue, or is this separate?

from markdown-transform.

K-Kumar-01 avatar K-Kumar-01 commented on August 28, 2024

@irmerk This is a bit different, there wasn't a firm discussion on styling so I went with the basic one there which Dan approved at the time since we were focused on conversion. This needs some discussion on how we want it to look.

from markdown-transform.

irmerk avatar irmerk commented on August 28, 2024

Pinging @Michael-Grover on this.

from markdown-transform.

Michael-Grover avatar Michael-Grover commented on August 28, 2024

Hi @K-Kumar-01 , I'm having a bit of trouble understanding this issue, partially because I can't run this locally to see if for myself. Please excuse my many questions:

What does "wrapping it in the content control" mean? Can a Microsoft Word user see what content is wrapped in the content control versus what is not?

I'm not familiar with the styling constraints on a Microsoft Word plugin. What are some options we have for visually distinguishing a clause from the content around it?

My understanding is that the inside of this red box I drew is the clause. Is that correct? What is the grey box, and why does it wrap content that is not part of the clause? As a user I would expect the clause to have something like the gray box wrapped around it.
image

from markdown-transform.

K-Kumar-01 avatar K-Kumar-01 commented on August 28, 2024

@Michael-Grover
Apologies for the late reply.

What does "wrapping it in the content control" mean? Can a Microsoft Word user see what content is wrapped in the content control versus what is not?

Yes a user can see if text is wrapped in content control or not. A border appears around the content wrapped when hovered as shown above.

I'm not familiar with the styling constraints on a Microsoft Word plugin. What are some options we have for visually distinguishing a clause from the content around it?

Not too sure myself. From what I have worked upon, one can try few of the following:
coloring the text, highlighting the text, changing the font, changing the size.
Although these are not good ones as size changes need to be specific. If a user will change the size, then we won't be able to say that it will still lie in a clause. Same for the other things.

My understanding is that the inside of this red box I drew is the clause. Is that correct? What is the grey box, and why does it wrap content that is not part of the clause? As a user I would expect the clause to have something like the gray box wrapped around it.

The gray part is the template area.It was implemented by @algomaster99 in his GSoC period. Later, I, @dselman, and @algomaster99 decided to wrap only the clause. But on thinking deeply, there was a problem which I found. That was how to determine which templates are already inserted and bind things.
Explanation: Suppose a template contains 2 clauses. Then we need to wrap both clauses along with content controls.
Also, there shouldn't be more than one template of the same kind. This is only possible via an id if given to the template which we do as of now. If only the clause is wrapped, then some ids need to be given to each clause which is associated with the template and on reopening further processing so that content controls are properly matched.

from markdown-transform.

Michael-Grover avatar Michael-Grover commented on August 28, 2024

@K-Kumar-01 I would suggest looking into popular Word plugins that also differentiate a block of text from the whole document, and see some ways they achieve this. I don't think we should necessarily use styling such as font and size to differentiate clause text, because the author of the document may want their contract to look visually consistent.

from markdown-transform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.