GithubHelp home page GithubHelp logo

Comments (5)

acdlite avatar acdlite commented on July 20, 2024

Yes this was an oversight. It can be fixed by flipping lines 25 and 26. A PR would be great :)

from recompose.

istarkov avatar istarkov commented on July 20, 2024

For simplicity with line switch, omit on line 26 also can be removed. Otherwise it works like mapAndFilterPropsOnChange

from recompose.

hartzis avatar hartzis commented on July 20, 2024

@istarkov it appears mapAndFilterPropsOnChange is not a HOC in this library. I do like the idea of that though.

from recompose.

istarkov avatar istarkov commented on July 20, 2024

I meant that omit filtering was done because of merge order, if you switch lines 25 and 26, looks like there is no need to filter (omit) props taken from array.

from recompose.

hartzis avatar hartzis commented on July 20, 2024

I have the PR pretty much ready to go, but trying to run the tests local and they are currently failing with:
Module build failed: Error: The (relay-query) Babel 5 plugin is being run with Babel 6.

I think it is related to facebook/relay#889, and when they publish a new version it may be fixed.

I may just submit the PR and see if the travis build fails.

from recompose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.