GithubHelp home page GithubHelp logo

Comments (6)

acdlite avatar acdlite commented on June 16, 2024

Ah, so Babel's loose mode is supposed to account for this, but it looks like since I updated the release script (which builds and publishes the npm package), the .babelrc file is no longer enabled, since the script cds into each package directory.

Long term solution will be to upgrade to Babel 6 and compile down to IE8 compatible code; in the meantime, if you want to submit a PR that either 1) rewrites to the old school way or 2) fixes the release script so that the Babel command is run from the root directory, I will merge.

from recompose.

acdlite avatar acdlite commented on June 16, 2024

Here's the line where Babel is run https://github.com/acdlite/recompose/blob/master/scripts/release.js#L88

from recompose.

joshacheson avatar joshacheson commented on June 16, 2024

After looking at Babel's class property transformer it doesn't appear there is any consideration for loose mode: https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-class-properties/src/index.js

Because of this I'll be going down route #1 and refactor to basic old school syntax for these static class props

from recompose.

joshacheson avatar joshacheson commented on June 16, 2024

@acdlite do you want to keep the use of static class properties in tests? Obviously this will have no impact on ie8 compat and it is definitely a little nicer to read

from recompose.

acdlite avatar acdlite commented on June 16, 2024

Sure, that's fine

from recompose.

acdlite avatar acdlite commented on June 16, 2024

Fixed by #69

from recompose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.