GithubHelp home page GithubHelp logo

Comments (2)

dralletje avatar dralletje commented on June 19, 2024

This is actually a problem from lifecycle(). Lifecycle() runs the setup function in the constructor, which is, I guess, in Reacts perfect world a pure function as well (only setting state once). Calling the constructor becomes 'part of' the render function of the parent component, so something that calls .setState() in a constructor is considered an error (impure render function). For that reason, observeProps doesn't call .setState() till it is rendered, but uses .state = ... instead. This, however, does not trigger a rerender, thus you'll end up with old state.

Either lifecycle has to be altered to trigger in componentWillMount() ( @acdlite what is the reason it is on the constructor right now? ) or you should move the fetching/not fetching into the observeProps() function itself :-)

from recompose.

acdlite avatar acdlite commented on June 19, 2024

Closing because we got rid of lifecycle().

from recompose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.