GithubHelp home page GithubHelp logo

Comments (15)

AryanKhubchandani avatar AryanKhubchandani commented on July 17, 2024 1

I would like to take this up

Sure! I'll assign it to you. Best of Luck!

from fludget.

AryanKhubchandani avatar AryanKhubchandani commented on July 17, 2024 1

@jushutch Let me know if you are interested in working on this issue.

I'd be happy to work on this issue!

Cool, I will assign it to you. Good luck!

from fludget.

AryanKhubchandani avatar AryanKhubchandani commented on July 17, 2024 1

Amazing @jushutch! The task was a little tedious, no doubt. But GG on being able to implement it properly!

from fludget.

acmbot avatar acmbot commented on July 17, 2024

This issue has been approved by the owner and is open to solve!
@AryanKhubchandani got 5 points for this issue! 🎉

from fludget.

umang-sinha avatar umang-sinha commented on July 17, 2024

I would like to take this up

from fludget.

umang-sinha avatar umang-sinha commented on July 17, 2024

@AryanKhubchandani A lot of text colour values and background colour values inside the app have been hardcoded to white and grey[900] respectively which makes it really difficult to apply dynamic theming as the hard coded values override any colours declared in theme data.
As of now, the only solution I can think of is to modify each and every instance of hard coded colour values which would be a very very tedious process. What do you suggest?

from fludget.

AryanKhubchandani avatar AryanKhubchandani commented on July 17, 2024

@AryanKhubchandani A lot of text colour values and background colour values inside the app have been hardcoded to white and grey[900] respectively which makes it really difficult to apply dynamic theming as the hard coded values override any colours declared in theme data. As of now, the only solution I can think of is to modify each and every instance of hard coded colour values which would be a very very tedious process. What do you suggest?

I am aware of the hard coded values and it is a part of this issue to resolve this problem as well. I don't feel it will be as tedious, but if you have any concerns, do let me know.

from fludget.

jushutch avatar jushutch commented on July 17, 2024

@umang-sinha Let me know if you want help with this, I'd be happy to work together!

from fludget.

AryanKhubchandani avatar AryanKhubchandani commented on July 17, 2024

Hey @umang-sinha, can you please update me regarding your progress with the issue?

from fludget.

umang-sinha avatar umang-sinha commented on July 17, 2024

Hey, please assign this to someone else

from fludget.

AryanKhubchandani avatar AryanKhubchandani commented on July 17, 2024

Hey, please assign this to someone else

Sure

from fludget.

AryanKhubchandani avatar AryanKhubchandani commented on July 17, 2024

@jushutch Let me know if you are interested in working on this issue.

from fludget.

jushutch avatar jushutch commented on July 17, 2024

@jushutch Let me know if you are interested in working on this issue.

I'd be happy to work on this issue!

from fludget.

AryanKhubchandani avatar AryanKhubchandani commented on July 17, 2024

@jushutch Can you update me with your progress?

from fludget.

jushutch avatar jushutch commented on July 17, 2024

@AryanKhubchandani So far it's going well, I finished building the themes and implementing a toggle in the Settings menu and everything is working. Now I'm working on updating all of the pages to use the new themes, which is definitely taking the longest. I've attached screenshots below to show that the toggle is working. If you want, I could also push my branch with my progress so far so you could check it out locally. I'm hoping to finish the entire feature by the end of tomorrow. Let me know if you have any initial thoughts or feedback!

Screenshots:
localhost_62089_(iPhone X) (3)
localhost_62089_(iPhone X) (2)
localhost_62089_(iPhone X) (1)
localhost_62089_(iPhone X)

from fludget.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.