Comments (5)
@sarahjean Could you be more specific? The current patternset for files.frontend is:
<patternset id="files.frontend">
<include name="**/*.js"/>
<!-- Ignore CSS. SASS usage is expected. CSS should be compiled. -->
<exclude name="**/*.css"/>
<exclude name="**/bower_components/**/*"/>
<exclude name="**/css/**"/>
<exclude name="**/dist/**/*"/>
<exclude name="**/lib/**/*"/>
<exclude name="**/node_modules/**/*"/>
<exclude name="**/styleguide/**"/>
<exclude name="**/vendor/**/*"/>
<exclude name="**/gulpfile.js"/>
</patternset>
This is including JS and is excluding a number of common third party directories. What is your goal? What should be excluded or included and why?
from blt.
@grasmash Yes, currently it grabs any and all JS, I am suggesting that it specifically look at JS provided by the theme, in a /js or /scripts folder, that way this doesn't need to be modified to exclude JS that might be in locations other than that which might not need to conform to Drupal Coder conventions (third party libraries, additional gulp or grunt files, code in node_modules, etc...)
A specific case that came up is in addition to <exclude name="**/gulpfile.js"/>
, there was a sub directory with gulp tasks being imported which needed to be added on. Since Drupal themes typical include a /js, /scripts, or similar folder if we specifically target that we won't need to do as many one-off excludes.
from blt.
@grasmash A slightly better version:
<patternset id="files.frontend">
<include name="**/js/**/*.js"/>
<include name="**/js/**/*.min.js"/>
<exclude name="**/node_modules/**/*"/>
<exclude name="**/vendor/**/*"/>
</patternset>
Not excluding node_modules caused some local performance issues when trying to run validate:phpcs
from blt.
It seems odd that we should need to exclude node_modules. Was your node_modules dir nested under a js dir?
from blt.
@grasmash No, actually. I'm not sure what was happening there.
I think bigger picture it'd be good if this list could be updated via project.yml.
from blt.
Related Issues (20)
- BLT-5202: Guzzle 7 Breaks Run-server Command
- BLT-5206: Remove cache.php, no longer needed for drush HOT 5
- BLT-5207: BLT excludes drush/Commands/custom
- BLT-5208: Replace abandoned composer package 'webmozart/path-util'
- BLT-5209: [info] Waiting for non-50x response from http://localhost:9222... HOT 4
- BLT-5211: acquia blt documentation is outdated, causing crashes and installation issues HOT 6
- BLT-5213: local.settings.php is not detecting on Acquia cloud IDE. HOT 1
- BLT-5215: UserConfig Class not found HOT 3
- BLT-5216: drupal:sync:default:site requires --no-interaction during ci on pipelines HOT 1
- BLT-5217: Undefined array key "bootstrap" for Inspector when Drupal is not installed
- drupal:sync:default:site and ckeditor 4 removal and other updb issues HOT 3
- Drush Launcher busted with Drush 12 HOT 6
- Additional logging during drupal:update command
- BLT-5223: BLT build starts failing after upgrade to 13.7 with Drush 12.1 HOT 1
- BLT-5224: Add back PHP code sniffing in pre-commit hook HOT 2
- Respect PHP and Drupal error logging HOT 1
- BLT-5228: test issue
- BLT-5229: How to hook into artifact:build when using deploy command
- BLT-5231: Update assertion handling to remove use of deprecated class HOT 1
- Announcing BLT’s End of Life HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blt.