Comments (8)
Yay! I've been wanting to add this but I didn't know what tool would provide the linting.
from blt.
@TravisCarden I don't appear to have a vendor/bin/console
despite having symfony/console as a dependency. What package version are you using?
from blt.
lint:twig
is documented under the Templating component (symfony/templating
). Perhaps it's provided separately by that? (I never implemented this. I just saw it in the documentation.)
from blt.
Hm. Having trouble getting that binary to show up in the bin directory. Tried requiring both symfony/templating and symfony/console.
I wonder if we need to create a custom app and register those commands. It seems like that shouldn't be necessary.
from blt.
Looks like this is part of symfony/symfony
and is registered in https://github.com/symfony/symfony/blob/2.8/src/Symfony/Bridge/Twig/Command/LintCommand.php.
Maybe we should look at a lighter-weight solution like https://github.com/asm89/twig-lint.
from blt.
So, lots of Symfony learning. Firstly, Symfony has a nightly build process that creates separate packagist projects for each component via git subtree. The lint command is part of symfony/twig-bridge.
The lint command can be registered with our own blt-console bin in one of two ways:
- We can convert blt-console to a full fledged Symfony app and register the twig-bridge bundle in a custom AppKernel, see https://github.com/grasmash/bolt/tree/issue-44-twig-app. This is pretty heavy weight but lets use quickly register new bundles easily.
- Leave blt-console as a standalone bundle and simple register the lint command (alone) in blt-console. See https://github.com/grasmash/bolt/tree/issue-44-add-lint-twig
from blt.
Command was added but is not yet being executed in pre-commit hook.
from blt.
Command currently exists in blt, ./vendor/bin/blt-console twig:lint --help
from blt.
Related Issues (20)
- BLT-5206: Remove cache.php, no longer needed for drush HOT 5
- BLT-5207: BLT excludes drush/Commands/custom
- BLT-5208: Replace abandoned composer package 'webmozart/path-util'
- BLT-5209: [info] Waiting for non-50x response from http://localhost:9222... HOT 4
- BLT-5211: acquia blt documentation is outdated, causing crashes and installation issues HOT 6
- BLT-5213: local.settings.php is not detecting on Acquia cloud IDE. HOT 1
- BLT-5215: UserConfig Class not found HOT 3
- BLT-5216: drupal:sync:default:site requires --no-interaction during ci on pipelines HOT 1
- BLT-5217: Undefined array key "bootstrap" for Inspector when Drupal is not installed
- drupal:sync:default:site and ckeditor 4 removal and other updb issues HOT 3
- Drush Launcher busted with Drush 12 HOT 6
- Additional logging during drupal:update command
- BLT-5223: BLT build starts failing after upgrade to 13.7 with Drush 12.1 HOT 1
- BLT-5224: Add back PHP code sniffing in pre-commit hook HOT 2
- Respect PHP and Drupal error logging HOT 1
- BLT-5228: test issue
- BLT-5229: How to hook into artifact:build when using deploy command
- BLT-5231: Update assertion handling to remove use of deprecated class HOT 1
- Announcing BLT’s End of Life HOT 13
- Core file web/core/lib/Drupal/Core/FileTransfer/Local.php is being ignored due to .gitignore config
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blt.