GithubHelp home page GithubHelp logo

Comments (6)

ba66e77 avatar ba66e77 commented on July 25, 2024

As an attempt at a workaround, I tried the following process and while it worked to push code, the site is failing because the vendor directory is gitignored in the deploy directory, so isn't committed and pushed to the target repo.

  • ./bolt.sh deploy:artifact:build
  • added my user creds to git config of deploy dir
  • ./bolt.sh deploy:artifact:commit -Ddeploy.commitMsg="--commit message---"
  • ./bolt.sh deploy:artifact:push-all -Ddeploy.branch='--target branch name--'

from blt.

grasmash avatar grasmash commented on July 25, 2024

Hm. This is a tricky problem.

We've found that it's best to wipe out the deploy directory prior to generating the artifact, since it's the only way to ensure a clean build.

I'm thinking the only two options are:

  1. Don't wipe out the deploy dir. This would allow your manually git config to persist, but the steps necessary feel ugly.
  2. Allow git username and email to be configurable by Bolt. This is a bit tough because it's local machine specific, and cannot be committed to the repo. We'd need to re-introduce a local.yml file. @danepowell @geerlingguy I feel like we had other reasons to consider re-introducing a local.yml. I like keeping the number of config files to a minimum, but I'm open to input!

from blt.

danepowell avatar danepowell commented on July 25, 2024

Preserving the deploy/.git directory isn't a crazy idea. In fact it ties in nicely to #22. So both of these issues could probably be solved together.

I don't think I want to build in specific support for a git username and email, since it really seems like an edge case. Deploys are typically run from a CI tool, and I can't imagine a scenario where a dedicated CI tool needs to support multiple Git identities for deployments. Feel free to prove me wrong though.

from blt.

danepowell avatar danepowell commented on July 25, 2024

Well, #22 was solved differently, I agree with Matt that preserving the .git directory isn't the best solution to this.

My recommendation would be to support two new arguments (git.email and git.username or something) that deploy:commit uses. And these could be added to project.local.yml.

@ba66e77 is this still a requirement for you?

from blt.

ba66e77 avatar ba66e77 commented on July 25, 2024

Yes, it still is. I've swallowed my pride and removed the useConfigOnly option in order to work around it, but that causes its own set of issues. I'd dearly love if this could be supported somehow.

Setting the new arguments you mentioned in the project.local.yml certainly seems viable to me.

from blt.

danepowell avatar danepowell commented on July 25, 2024

@ba66e77 feel like testing #1323?

You can apply it as a patch to an existing project like so: https://patch-diff.githubusercontent.com/raw/acquia/blt/pull/1323.patch

from blt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.