Comments (6)
As an attempt at a workaround, I tried the following process and while it worked to push code, the site is failing because the vendor directory is gitignored in the deploy directory, so isn't committed and pushed to the target repo.
- ./bolt.sh deploy:artifact:build
- added my user creds to git config of deploy dir
- ./bolt.sh deploy:artifact:commit -Ddeploy.commitMsg="--commit message---"
- ./bolt.sh deploy:artifact:push-all -Ddeploy.branch='--target branch name--'
from blt.
Hm. This is a tricky problem.
We've found that it's best to wipe out the deploy directory prior to generating the artifact, since it's the only way to ensure a clean build.
I'm thinking the only two options are:
- Don't wipe out the deploy dir. This would allow your manually git config to persist, but the steps necessary feel ugly.
- Allow git username and email to be configurable by Bolt. This is a bit tough because it's local machine specific, and cannot be committed to the repo. We'd need to re-introduce a local.yml file. @danepowell @geerlingguy I feel like we had other reasons to consider re-introducing a local.yml. I like keeping the number of config files to a minimum, but I'm open to input!
from blt.
Preserving the deploy/.git
directory isn't a crazy idea. In fact it ties in nicely to #22. So both of these issues could probably be solved together.
I don't think I want to build in specific support for a git username and email, since it really seems like an edge case. Deploys are typically run from a CI tool, and I can't imagine a scenario where a dedicated CI tool needs to support multiple Git identities for deployments. Feel free to prove me wrong though.
from blt.
Well, #22 was solved differently, I agree with Matt that preserving the .git directory isn't the best solution to this.
My recommendation would be to support two new arguments (git.email
and git.username
or something) that deploy:commit
uses. And these could be added to project.local.yml
.
@ba66e77 is this still a requirement for you?
from blt.
Yes, it still is. I've swallowed my pride and removed the useConfigOnly option in order to work around it, but that causes its own set of issues. I'd dearly love if this could be supported somehow.
Setting the new arguments you mentioned in the project.local.yml certainly seems viable to me.
from blt.
@ba66e77 feel like testing #1323?
You can apply it as a patch to an existing project like so: https://patch-diff.githubusercontent.com/raw/acquia/blt/pull/1323.patch
from blt.
Related Issues (20)
- BLT-5202: Guzzle 7 Breaks Run-server Command
- BLT-5206: Remove cache.php, no longer needed for drush HOT 5
- BLT-5207: BLT excludes drush/Commands/custom
- BLT-5208: Replace abandoned composer package 'webmozart/path-util'
- BLT-5209: [info] Waiting for non-50x response from http://localhost:9222... HOT 4
- BLT-5211: acquia blt documentation is outdated, causing crashes and installation issues HOT 6
- BLT-5213: local.settings.php is not detecting on Acquia cloud IDE. HOT 1
- BLT-5215: UserConfig Class not found HOT 3
- BLT-5216: drupal:sync:default:site requires --no-interaction during ci on pipelines HOT 1
- BLT-5217: Undefined array key "bootstrap" for Inspector when Drupal is not installed
- drupal:sync:default:site and ckeditor 4 removal and other updb issues HOT 3
- Drush Launcher busted with Drush 12 HOT 6
- Additional logging during drupal:update command
- BLT-5223: BLT build starts failing after upgrade to 13.7 with Drush 12.1 HOT 1
- BLT-5224: Add back PHP code sniffing in pre-commit hook HOT 2
- Respect PHP and Drupal error logging HOT 1
- BLT-5228: test issue
- BLT-5229: How to hook into artifact:build when using deploy command
- BLT-5231: Update assertion handling to remove use of deprecated class HOT 1
- Announcing BLT’s End of Life HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blt.