GithubHelp home page GithubHelp logo

Comments (9)

cdb avatar cdb commented on July 17, 2024 1

@ibakshay - I don't know for sure about this exact example, but we are working on some fixes related to re-runs in particular, where the event data on the rerun isn't exactly the same as the original event data.

I'll link this issue with our internal tracking issue for that work and do my best to remember to let you know here when we've deployed any changes. Thanks for the feedback!

from toolkit.

cdb avatar cdb commented on July 17, 2024 1

@ibakshay - Some coworkers are putting a fix together that I believe will address this for you. I don't have an ETA for you though. This issue is staying in my inbox so I don't forget to report back ;)

from toolkit.

ibakshay avatar ibakshay commented on July 17, 2024

Could you please tell Whether It is a bug or I am missing something ? πŸ˜….
Now after triggering Re_run checks, check status is pending forever.
https://github.com/ibakshay/test-action-workflow/commit/d2ad0ceb384864f55f21ce9bf3687b92015913e7/checks
Screen Shot 2019-09-09 at 16 45 42

Screen Shot 2019-09-09 at 16 53 55

from toolkit.

ibakshay avatar ibakshay commented on July 17, 2024

I debugged and found out that the re-run checks is not working when there is a filter something like

    - name: "TEST ACTION"
      if: github.event.action == 'opened' || github.event.action == 'edited'
      uses: ibakshay/action-template@dev
      with: 
        mytoken: ${{ secrets.GITHUB_TOKEN }}

If the remove the filter if: github.event.action == 'opened' || github.event.action == 'edited' for that step, then re-run checks is working fine.

I have checked for both pull_request and the issues event. The same issue is there when there is a filter for both the events.

from toolkit.

damccorm avatar damccorm commented on July 17, 2024

@cdb any idea what's going on here? It looks like maybe we're populating a different event in the context on re-run, that doesn't seem right to me, but I'm not sure

from toolkit.

ibakshay avatar ibakshay commented on July 17, 2024

Hi @damccorm , thank you for your response. I am facing issues with 're-run' only when there is a filter in the workflow file like I mentioned in my above comment.

from toolkit.

ibakshay avatar ibakshay commented on July 17, 2024

Hi @cdb, thank you for the update. Is there any progress on this issue ? πŸ˜ƒ .. when i debugged, I found out that I am also facing the same issue. During re-run some other context is triggered.

from toolkit.

cdb avatar cdb commented on July 17, 2024

@ibakshay - We've rolled out updates on our end for ensuring a re-run gets the same event data as the original run. Hopefully this will help you out on this issue?

from toolkit.

ibakshay avatar ibakshay commented on July 17, 2024

Hi @cdb, I just checked and re-run is working great now πŸ’―πŸ˜„. Thank you very much for being responsive and letting me know after rolling out the update ..

from toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.