Comments (12)
That's correct, we're holding off releasing the toolkit till the fix is in the runner. I will update this issue so you can monitor here.
You are not forced to use the toolkit - it's a convenience. You can echo from scripts which is all the toolkit does.
::
is the official way going forward for all commands and group will work once our pools are updated in the next day or two. ##
will work for quite some time back compat.
https://github.com/actions/toolkit/blob/master/docs/commands.md
echo ::group::my title . # this is the official way
echo ::ungroup::
Nested groups are not in scope for GA. Grouping is a log web UI / service feature and I've created a feedback issue for that team.
from toolkit.
@bryanmacfarlane, thanks a lot for clarifying, and for forwarding feedback to the team.
from toolkit.
@1138-4eb , product suggested creating a discussion @ https://github.community and referencing this issue for the nested groups suggestion.
from toolkit.
This is released and I updated the docs: https://github.com/actions/toolkit/blob/master/docs/commands.md#group-and-ungroup-log-lines
from toolkit.
(sigh) typo in docs.
It's endgroup. I just updated the docs.
Thanks for catching that.
from toolkit.
@bryanmacfarlane, related to #57 (comment), currently ::[
seems to be broken, but ##[
works: https://github.com/1138-4EB/rpm-ghdl/commit/5833e06119274d24f5806fc7b1457b8532275272/checks. Both of them worked ok until a few hours/days ago.
from toolkit.
Core has functions but they are not working with runner. We are fixing.
https://github.com/actions/toolkit/blob/master/packages/core/src/core.ts#L150
from toolkit.
Core has functions but they are not working with runner.
Actually, master
version of core is using ::
(https://github.com/actions/toolkit/blob/master/packages/core/src/command.ts#L32). But that was changed 8 days ago, and the latest release is from 19 days ago (https://github.com/actions/toolkit/blob/%40actions/core%401.1.0/packages/core/src/core.ts).
Therefore, the latest release of core works ok now because it still uses ##
. As soon as a new release is published, it will be broken (as the ref above shows).
FTR, https://github.com/1138-4EB/actions/blob/master/src/main.ts#L10-L12 is an example of an action that uses this group feature of core. And this is an example log generated with it: https://github.com/1138-4EB/actions/commit/92a6da98ce69920b56e9d2b06b3a8b18be7ce88a/checks#step:2:8
We are fixing.
Is there any issue that I can subscribe to? As commented in #57, I'm actually using bash scripts to generate these commands/tags. I'd rather not be forced to have a complex TypeScript/JavaScript project just to be aware of when this is fixed.
BTW, is there anyone I should /cc
in order to have some brief reply to the first comment in this issue? With the current repo/support structure, many Actions-related questions seem out of context and gathering very little attention...
from toolkit.
from toolkit.
In the new docs, echo ::ungroup::
is shown, but the toolkit is still producing ::endgroup::
, according to https://github.com/actions/toolkit/blob/master/packages/core/src/command.ts#L32 and https://github.com/actions/toolkit/blob/master/packages/core/src/core.ts#L157. Which one is correct/up-to-date?
from toolkit.
@bryanmacfarlane, this is still broken. Would you mind reopening this issue?
Please, find a reproducer in https://github.com/1138-4EB/actions/tree/test-groups and https://github.com/1138-4EB/actions/commit/f0d4c7dc00da0544f73463fb8b0db72cec5b1a01/checks?check_suite_id=276862247. Five different methods are used to create a group:
core.js
: core.group feature of @actions/coredots.js
: plain javascript using::
dots.sh
: bash using::
hash.js
: plain javascript using##
hash.sh
: bash using##
Each of the scripts is executed in a different step, and core.js
is executed twice (once on the host and once in a docker container). For each execution, hexadecimal values (ASCII) are shown apart from the regular output.
Surprinsingly, although the sources of core.js
use ::
, at some point it is converted to ##
. As a result, core.js
produces the same output as hash.*
, which looks correct. However, dots.*
produce a broken output, even though these are the ones that are expected to be supported. Looking at the hex output, it can be seen that the output of core.js
does indeed match the output of dots.*
and not the one of hash.*
.
js core
GroupName
0000000 3a 3a 67 72 6f 75 70 3a 3a 47 72 6f 75 70 4e 61
0000020 6d 65 0a 48 65 6c 6c 6f 0a 3a 3a 65 6e 64 67 72
0000040 6f 75 70 3a 3a 0a
0000046
js hash
GroupName
0000000 23 23 5b 67 72 6f 75 70 5d 47 72 6f 75 70 4e 61
0000020 6d 65 0a 48 65 6c 6c 6f 0a 23 23 5b 65 6e 64 67
0000040 72 6f 75 70 5d 0a
0000046
js dots
p]GroupName
0000000 3a 3a 5b 67 72 6f 75 70 5d 47 72 6f 75 70 4e 61
0000020 6d 65 0a 48 65 6c 6c 6f 0a 3a 3a 5b 65 6e 64 67
0000040 72 6f 75 70 5d 0a
0000046
bash hash
GroupName
0000000 23 23 5b 67 72 6f 75 70 5d 47 72 6f 75 70 4e 61
0000020 6d 65 0a 48 65 6c 6c 6f 0a 23 23 5b 65 6e 64 67
0000040 72 6f 75 70 5d 0a
0000046
bash dots
p]GroupName
0000000 3a 3a 5b 67 72 6f 75 70 5d 47 72 6f 75 70 4e 61
0000020 6d 65 0a 48 65 6c 6c 6f 0a 3a 3a 5b 65 6e 64 67
0000040 72 6f 75 70 5d 0a
0000046
EDIT
Oh, my bad. After reading this again and again, I found that I was using ::[group]
instead of ::group::
. Now all of them are converted automatically and shown properly. Sorry for bothering you.
from toolkit.
@1138-4eb - NP. Thanks for confirming.
from toolkit.
Related Issues (20)
- https://www.facebook.com/nara.istri.jisung
- `continue-on-error` should not return `success` in ` needs_job_result`
- Make uploadZipToBlobStorage() log raw and compressed sizes ?
- Annotations using environment files
- amin HOT 1
- npm i @actions/glob
- Bug
- Spacextool
- @actions/cache tar doesn't specify --xattrs
- @actions/github hasn't been published in 8 months
- Support storing and restoring cache entries as buffers. HOT 1
- mkdir service-selling-app cd service-selling-app HOT 1
- mkdir service-selling-app
- @actions/core: Add support for full width tables and column width
- BornNk
- Plan for transition to ESM?
- actions/exec: Allow timeout on running a process
- URL-encoding not handled for proxy username.(http-client)
- Property body of WebhookPayload should be string | null not optional
- OidcClient.getCall failing in self-hosted Runners.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from toolkit.