Comments (20)
Done. Changed it to node12-template
Ting is also moving the runner to node 12 this morning.
from toolkit.
Both the container action and the vm / host based can both run javascript (thus the toolkit for both written in javascript). The key difference is one runs on the host / vm and one runs the logic in a container.
I would suggest host-template and container-template.
I'll defer on renaming till @vtbassmatt confirms
from toolkit.
Could you create a repo for this and #17 in the actions org?
from toolkit.
These should be template repositories I would think https://github.blog/2019-06-06-generate-new-repositories-with-repository-templates/
from toolkit.
@chrispat - I like that suggestion. Any preference on the repo name?
@vtbassmatt as fyi
from toolkit.
No preference on the repo name I will leave it to @vtbassmatt to figure out
from toolkit.
I will pick some. Rename is an awesome feature ;)
from toolkit.
https://github.com/actions/start-vm-action
from toolkit.
I think we're calling them "javascript actions" so I'll rename that ;)
from toolkit.
Added a first draft template, I don't have admin privileges though so I can't mark it a template repo
from toolkit.
@damccorm - done
from toolkit.
Made it a template action. Also renamed it to actions/javascript-template since I think that's closer to what we're looking for in terms of branding. @vtbassmatt if you have another name in mind feel free to update
from toolkit.
The names I've been using - and trying to make official - are "container actions" and "JavaScript actions". I think that distinction will resonate more with customers than host/VM, but rather than speculate, let me ask for a quick study from UX.
from toolkit.
Note that we do have a handler concept so we can add the ability to write actions in other scripting languages. For example, we've considered powershell core but perhaps in the future python or bash is an option.
So expanding on your distinction, I would suggest container
and script
actions as the general marketing terms. However, since this specific template is for a javascript task then inline with that, it would be fine to use javascript-template
. A final option would be a node-template since it's really just not javascript, it's specifically node that we run it with.
If we wanted to look a little bit ahead, we might want to call this the node12-template
as we are about to change the runner to carry 12 (just LTS) and the files that would be in the template (node d.ts etc) and the handler would have to be node12, would be specific to node12. It would also drive home exactly what's going to happen.
Thoughts?
from toolkit.
I actually like that. How about node12-vm-template
since we're being that precise?
from toolkit.
(or node12-host-template
since not all non-container is VM... now I'm splitting hairs though...)
from toolkit.
I think node12-template
is fine.
from toolkit.
Cool, thanks! For consistency, does actions/container-template
make sense for the other template repo?
from toolkit.
Yes. Just renamed it to container-template
@damccorm - after you get done with node12 template, start on that one. We should decide what base image we want to encourage in that template. I think a node alpine container from docker hub is good for a compute or SDLC type container action.
from toolkit.
Going to close here since the template is done. We can follow up with any proposed changes as issues in that repo.
from toolkit.
Related Issues (20)
- scoop install 1password-cli
- Dependencies: Public docs no longer match some API methods HOT 1
- Unix file permissions not stored in zip file HOT 1
- actions/cache assumes zstdmt to be installed HOT 1
- Cannot use `@actions/github` and `@actions/artifact` together
- Tracking
- @actions/artefacts weighs 100mb. this cant be right
- 2024 老牌机场推荐:老牌机场合集
- Bug: `context.job` fails to take into account `jobs.<job_id>.name` value HOT 2
- https://www.facebook.com/nara.istri.jisung
- `continue-on-error` should not return `success` in ` needs_job_result`
- Make uploadZipToBlobStorage() log raw and compressed sizes ?
- Annotations using environment files
- amin HOT 1
- npm i @actions/glob
- Bug
- Spacextool
- @actions/cache tar doesn't specify --xattrs
- @actions/github hasn't been published in 8 months
- Support storing and restoring cache entries as buffers. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from toolkit.