GithubHelp home page GithubHelp logo

Don't create checks on issues about toolkit HOT 7 CLOSED

actions avatar actions commented on August 16, 2024 3
Don't create checks on issues

from toolkit.

Comments (7)

gimenete avatar gimenete commented on August 16, 2024 3

@damccorm I'll create an internal issue. The problem is that when an event not related to a push triggers Actions, Actions searches the latest version of the workflow files. In order to do that it uses the latest commit in the default branch. This makes sense in order to decide which version of the workflow file is used. Then checks are created and the SHA is stored in them. These checks need to be created to show up in the Actions tab and be able to debug anything.

However that SHA used to find the right workflow file version may also be the latest SHA in a PR, which causes the checks to appear in the merge box (and probably other places of the UI) and this is what's happening here, which is confusing to the users.

from toolkit.

damccorm avatar damccorm commented on August 16, 2024 2

@gimenete actions/stale#13 looks like the same issue

from toolkit.

estrada9166 avatar estrada9166 commented on August 16, 2024 1

I have this workflow

name: "Issue assigner"

on: [issues, issue_comment]

jobs:
  triage:
    runs-on: ubuntu-latest
    steps:
    - name: Issue assigner
      if: github.event.action == 'created' || github.event.action == 'opened'
      uses: estrada9166/issue-assigner@v1
      with:
        GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
        WITH_COMMENTS: true

Screen Shot 2019-08-26 at 3 28 35 PM

from toolkit.

gimenete avatar gimenete commented on August 16, 2024 1

We have shipped a fix for this. Here's a blog post with more information https://github.blog/changelog/2019-09-24-ui-changes-in-github-actions-checks/

from toolkit.

damccorm avatar damccorm commented on August 16, 2024

What are you triggering your workflow on? In theory on: issues should have this behavior and shouldn't create any checks

from toolkit.

damccorm avatar damccorm commented on August 16, 2024

@gimenete you did some work on checks right? This looks like unexpected behavior to me, could you take a look (or repath to someone better)?

from toolkit.

bryanmacfarlane avatar bryanmacfarlane commented on August 16, 2024

Closing here since not toolkit related and tracking internally

from toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.