Problem deleting a tasks candidate groups when there are candidate users about activiti

[henryyan]

You can create a pull request to fix this issue.—
Sent from Mailbox for iPad

On Wed, Jul 23, 2014 at 6:51 PM, StuartWT [email protected]
wrote:

If I have a task which has candidate users and candidate groups and I want to change them (using TaskService.deleteCandidateGroup()), I get a null error.
Debugging the code, we end up in org.activiti.engine.impl.persistence.entity.deleteIdentityLink(String userId, String groupId, String type).
The line of code with the issue is
if ((userId != null && userId.equals(identityLinkEntity.getUserId()))
|| (groupId != null && identityLinkEntity.getGroupId().equals(groupId))) {
, where the inner most if() compares:
groupId != null && identityLinkEntity.getGroupId().equals(groupId)
If we are looking at a candidate user link, identityLinkEntity.getGroupId() is null, so we get the error. Perhaps this line should be changed to compare in a similar fashion to the user comparison in the same if, i.e.

groupId != null && groupId.equals(identityLinkEntity.getGroupId()

Reply to this email directly or view it on GitHub:
#339